summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrpereira2 <rpereira@gitlab.com>2019-02-01 16:38:22 +0530
committerrpereira2 <rpereira@gitlab.com>2019-02-06 21:04:37 +0530
commit29c3c93b9aa61b5a2f243835ba81a052b1d429f4 (patch)
treeef10531533c8ed71de0b2506ef0e85aefbe901de
parentfbc102f2fc8eb02326f707fae3e5a8fbf1084f00 (diff)
downloadgitlab-ce-29c3c93b9aa61b5a2f243835ba81a052b1d429f4.tar.gz
Move test setup into a before block
-rw-r--r--spec/services/error_tracking/list_sentry_projects_service_spec.rb14
1 files changed, 10 insertions, 4 deletions
diff --git a/spec/services/error_tracking/list_sentry_projects_service_spec.rb b/spec/services/error_tracking/list_sentry_projects_service_spec.rb
index 32607cec590..ad9ea56f279 100644
--- a/spec/services/error_tracking/list_sentry_projects_service_spec.rb
+++ b/spec/services/error_tracking/list_sentry_projects_service_spec.rb
@@ -53,14 +53,20 @@ describe ErrorTracking::ListSentryProjectsService do
end
context 'with invalid url' do
- it 'returns error' do
- error_tracking_setting.enabled = false
- params = ActionController::Parameters.new(
+ let(:params) do
+ ActionController::Parameters.new(
api_host: 'https://localhost',
token: new_token
)
- subject = described_class.new(project, user, params)
+ end
+
+ subject { described_class.new(project, user, params) }
+ before do
+ error_tracking_setting.enabled = false
+ end
+
+ it 'returns error' do
result = subject.execute
expect(error_tracking_setting).not_to be_valid