summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrpereira2 <rpereira@gitlab.com>2019-02-01 16:59:54 +0530
committerrpereira2 <rpereira@gitlab.com>2019-02-07 10:37:07 +0530
commitcf558ff3431b96c7ebc33c73eb409f8843351ca8 (patch)
tree1eac5c30ba6038d51bb477f686fae910a44f2193
parent62d18103241f6f58e211eefac225832ede36b8e9 (diff)
downloadgitlab-ce-cf558ff3431b96c7ebc33c73eb409f8843351ca8.tar.gz
Remove html response code
-rw-r--r--app/controllers/projects/settings/operations_controller.rb9
-rw-r--r--spec/controllers/projects/settings/operations_controller_spec.rb28
2 files changed, 0 insertions, 37 deletions
diff --git a/app/controllers/projects/settings/operations_controller.rb b/app/controllers/projects/settings/operations_controller.rb
index eccd02a9ef4..0b5ffd0b18c 100644
--- a/app/controllers/projects/settings/operations_controller.rb
+++ b/app/controllers/projects/settings/operations_controller.rb
@@ -15,15 +15,6 @@ module Projects
result = ::Projects::Operations::UpdateService.new(project, current_user, update_params).execute
respond_to do |format|
- format.html do
- if result[:status] == :success
- flash[:notice] = _('Your changes have been saved')
- redirect_to project_settings_operations_path(@project)
- else
- render 'show'
- end
- end
-
format.json do
if result[:status] == :success
render json:
diff --git a/spec/controllers/projects/settings/operations_controller_spec.rb b/spec/controllers/projects/settings/operations_controller_spec.rb
index cc10c8c3612..99568ddaa28 100644
--- a/spec/controllers/projects/settings/operations_controller_spec.rb
+++ b/spec/controllers/projects/settings/operations_controller_spec.rb
@@ -90,34 +90,6 @@ describe Projects::Settings::OperationsController do
ActionController::Parameters.new(error_tracking_params).permit!
end
- context 'format html' do
- context 'when update succeeds' do
- before do
- stub_operations_update_service_returning(status: :success)
- end
-
- it 'shows a notice' do
- patch :update, params: project_params(project, error_tracking_params)
-
- expect(response).to redirect_to(operations_url)
- expect(flash[:notice]).to eq _('Your changes have been saved')
- end
- end
-
- context 'when update fails' do
- before do
- stub_operations_update_service_returning(status: :error)
- end
-
- it 'renders show page' do
- patch :update, params: project_params(project, error_tracking_params)
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(response).to render_template(:show)
- end
- end
- end
-
context 'format json' do
context 'when update succeeds' do
before do