diff options
author | João Cunha <j.a.cunha@gmail.com> | 2019-07-03 13:38:54 +0100 |
---|---|---|
committer | João Cunha <j.a.cunha@gmail.com> | 2019-07-03 13:38:54 +0100 |
commit | e9e14e87b52db4c970c177e52ab481f934fcc081 (patch) | |
tree | 66adcd2cecf08cce2e7176f69b613d33ffc4c408 | |
parent | 0c79dae16569f7ca3effbf3dba7ad95efe5f90de (diff) | |
download | gitlab-ce-e9e14e87b52db4c970c177e52ab481f934fcc081.tar.gz |
Rename variable to represent what it really is
-rw-r--r-- | app/models/clusters/concerns/application_status.rb | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/app/models/clusters/concerns/application_status.rb b/app/models/clusters/concerns/application_status.rb index 54a3dda6d75..f842e6aaf81 100644 --- a/app/models/clusters/concerns/application_status.rb +++ b/app/models/clusters/concerns/application_status.rb @@ -59,29 +59,29 @@ module Clusters transition [:scheduled] => :uninstalling end - before_transition any => [:scheduled] do |app_status, _| - app_status.status_reason = nil + before_transition any => [:scheduled] do |application, _| + application.status_reason = nil end - before_transition any => [:errored] do |app_status, transition| + before_transition any => [:errored] do |application, transition| status_reason = transition.args.first - app_status.status_reason = status_reason if status_reason + application.status_reason = status_reason if status_reason end - before_transition any => [:updating] do |app_status, _| - app_status.status_reason = nil + before_transition any => [:updating] do |application, _| + application.status_reason = nil end - before_transition any => [:update_errored, :uninstall_errored] do |app_status, transition| + before_transition any => [:update_errored, :uninstall_errored] do |application, transition| status_reason = transition.args.first - app_status.status_reason = status_reason if status_reason + application.status_reason = status_reason if status_reason end - before_transition any => [:installed, :updated] do |app_status, _| + before_transition any => [:installed, :updated] do |application, _| # When installing any application we are also performing an update # of tiller (see Gitlab::Kubernetes::Helm::ClientCommand) so # therefore we need to reflect that in the database. - app_status.cluster.application_helm.update!(version: Gitlab::Kubernetes::Helm::HELM_VERSION) + application.cluster.application_helm.update!(version: Gitlab::Kubernetes::Helm::HELM_VERSION) end end end |