summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2019-08-02 16:32:40 +0000
committerRobert Speicher <rspeicher@gmail.com>2019-08-02 16:32:40 +0000
commit1bc2ac330e503005b6eec45c409f774178e3059f (patch)
tree104f1ab105bbc434a14beef62f3b4bb9d66f64e6
parent8374dd565d44e5f97c179dcb4cf03c7d3ea69363 (diff)
parent3b1da9be250560c9a2e4ca69c6fa89e8b36f01e1 (diff)
downloadgitlab-ce-1bc2ac330e503005b6eec45c409f774178e3059f.tar.gz
Merge branch '17276-breakage-in-displaying-svg-in-the-same-repository' into 'master'
Resolve "Breakage in displaying SVG in the same repository" See merge request gitlab-org/gitlab-ce!31352
-rw-r--r--changelogs/unreleased/17276-breakage-in-displaying-svg-in-the-same-repository.yml5
-rw-r--r--lib/gitlab/blob_helper.rb2
-rw-r--r--spec/models/commit_spec.rb1
3 files changed, 7 insertions, 1 deletions
diff --git a/changelogs/unreleased/17276-breakage-in-displaying-svg-in-the-same-repository.yml b/changelogs/unreleased/17276-breakage-in-displaying-svg-in-the-same-repository.yml
new file mode 100644
index 00000000000..93936d441e7
--- /dev/null
+++ b/changelogs/unreleased/17276-breakage-in-displaying-svg-in-the-same-repository.yml
@@ -0,0 +1,5 @@
+---
+title: Fix inline rendering of relative paths to SVGs from the current repository
+merge_request: 31352
+author:
+type: fixed
diff --git a/lib/gitlab/blob_helper.rb b/lib/gitlab/blob_helper.rb
index d3e15a79a8b..fc579ad8d2a 100644
--- a/lib/gitlab/blob_helper.rb
+++ b/lib/gitlab/blob_helper.rb
@@ -45,7 +45,7 @@ module Gitlab
end
def image?
- ['.png', '.jpg', '.jpeg', '.gif'].include?(extname.downcase)
+ ['.png', '.jpg', '.jpeg', '.gif', '.svg'].include?(extname.downcase)
end
# Internal: Lookup mime type for extension.
diff --git a/spec/models/commit_spec.rb b/spec/models/commit_spec.rb
index e76186fb280..7b35c2ffd36 100644
--- a/spec/models/commit_spec.rb
+++ b/spec/models/commit_spec.rb
@@ -556,6 +556,7 @@ eos
it 'returns the URI type at the given path' do
expect(commit.uri_type('files/html')).to be(:tree)
expect(commit.uri_type('files/images/logo-black.png')).to be(:raw)
+ expect(commit.uri_type('files/images/wm.svg')).to be(:raw)
expect(project.commit('video').uri_type('files/videos/intro.mp4')).to be(:raw)
expect(commit.uri_type('files/js/application.js')).to be(:blob)
end