summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2017-01-27 11:20:42 +0000
committerStan Hu <stanhu@gmail.com>2017-01-27 11:20:42 +0000
commitd64dfd7b236f0af79ffd4b485cc92977b8d0fa58 (patch)
treec961b818563514833239081ff172ddf409cd2cbd
parentda1d83e0aff3730e843388743291796a09aab765 (diff)
parent204020fc3332368e017f7fb2f6b106e83cb5baf7 (diff)
downloadgitlab-ce-d64dfd7b236f0af79ffd4b485cc92977b8d0fa58.tar.gz
Merge branch 'gemfile-development-guideline' into 'master'
Document "No gems fetched from git repositories" policy [ci skip] See merge request !8818
-rw-r--r--doc/development/README.md1
-rw-r--r--doc/development/gemfile.md14
2 files changed, 15 insertions, 0 deletions
diff --git a/doc/development/README.md b/doc/development/README.md
index 6f2ca7b8590..265df98fb87 100644
--- a/doc/development/README.md
+++ b/doc/development/README.md
@@ -18,6 +18,7 @@
- [Frontend guidelines](frontend.md)
- [SQL guidelines](sql.md) for working with SQL queries
- [Sidekiq guidelines](sidekiq_style_guide.md) for working with Sidekiq workers
+- [`Gemfile` guidelines](gemfile.md)
## Process
diff --git a/doc/development/gemfile.md b/doc/development/gemfile.md
new file mode 100644
index 00000000000..ec9718cea71
--- /dev/null
+++ b/doc/development/gemfile.md
@@ -0,0 +1,14 @@
+# `Gemfile` guidelines
+
+When adding a new entry to `Gemfile` or upgrading an existing dependency pay
+attention to the following rules.
+
+## No gems fetched from git repositories
+
+We do not allow gems that are fetched from git repositories. All gems have
+to be available in the RubyGems index. We want to minimize external build
+dependencies and build times.
+
+## License compliance
+
+Refer to [licensing guidelines](licensing.md) for ensuring license compliance.