summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabio Papa <fabtheman@gmail.com>2019-06-16 13:22:12 -0700
committerFabio Papa <fabtheman@gmail.com>2019-07-01 14:01:34 -0700
commite5f7ef0e77c5ab11f753347711088c8117b5b5dd (patch)
tree5dad32f1d2a922a99f403488d78858c1790bb223
parenteb27c2b164418da3ed75052657b364b740505b51 (diff)
downloadgitlab-ce-e5f7ef0e77c5ab11f753347711088c8117b5b5dd.tar.gz
Modify API spec to expect a maintainer to be able to create subgroup
-rw-r--r--spec/requests/api/groups_spec.rb4
-rw-r--r--spec/support/shared_contexts/policies/group_policy_shared_context.rb4
2 files changed, 2 insertions, 6 deletions
diff --git a/spec/requests/api/groups_spec.rb b/spec/requests/api/groups_spec.rb
index c41408fba65..52d926d5484 100644
--- a/spec/requests/api/groups_spec.rb
+++ b/spec/requests/api/groups_spec.rb
@@ -803,10 +803,10 @@ describe API::Groups do
group2.add_maintainer(user1)
end
- it 'cannot create subgroups' do
+ it 'can create subgroups' do
post api("/groups", user1), params: { parent_id: group2.id, name: 'foo', path: 'foo' }
- expect(response).to have_gitlab_http_status(403)
+ expect(response).to have_gitlab_http_status(201)
end
end
end
diff --git a/spec/support/shared_contexts/policies/group_policy_shared_context.rb b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
index b4b09d3295f..a40d3087f6e 100644
--- a/spec/support/shared_contexts/policies/group_policy_shared_context.rb
+++ b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
@@ -19,10 +19,6 @@ RSpec.shared_context 'GroupPolicy context' do
let(:reporter_permissions) { [:admin_label] }
let(:developer_permissions) { [:admin_milestone] }
let(:maintainer_permissions) do
- %i[
- create_projects
- read_cluster create_cluster update_cluster admin_cluster add_cluster
- ]
[
:create_projects,
:read_cluster,