summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClement Ho <clemmakesapps@gmail.com>2019-07-11 22:51:41 +0000
committerClement Ho <clemmakesapps@gmail.com>2019-07-11 22:51:41 +0000
commite1d1728d409b87916d82698ca107b2c7ba65507e (patch)
tree9ec5028a9590e199c8d6a4bdce152eb08b74e5af
parent4b6611f31d18fe03664bbde419926cc25f088c33 (diff)
parent7f8585c61831f18aa2d59879d251accda2fcbc7b (diff)
downloadgitlab-ce-e1d1728d409b87916d82698ca107b2c7ba65507e.tar.gz
Merge branch '64403-remove-setimmediate-polyfill' into 'master'
Remove setImmediate polyfill from production assets See merge request gitlab-org/gitlab-ce!30591
-rw-r--r--config/webpack.config.js6
-rw-r--r--spec/javascripts/helpers/vuex_action_helper.js4
-rw-r--r--spec/javascripts/test_bundle.js1
3 files changed, 6 insertions, 5 deletions
diff --git a/config/webpack.config.js b/config/webpack.config.js
index a81590e8b8e..cd793743eb7 100644
--- a/config/webpack.config.js
+++ b/config/webpack.config.js
@@ -344,6 +344,8 @@ module.exports = {
devtool: NO_SOURCEMAPS ? false : devtool,
- // sqljs requires fs
- node: { fs: 'empty' },
+ node: {
+ fs: 'empty', // sqljs requires fs
+ setImmediate: false,
+ },
};
diff --git a/spec/javascripts/helpers/vuex_action_helper.js b/spec/javascripts/helpers/vuex_action_helper.js
index 88652202a8e..c5de31a4138 100644
--- a/spec/javascripts/helpers/vuex_action_helper.js
+++ b/spec/javascripts/helpers/vuex_action_helper.js
@@ -89,9 +89,7 @@ export default (
payload,
);
- return new Promise(resolve => {
- setImmediate(resolve);
- })
+ return new Promise(setImmediate)
.then(() => result)
.catch(error => {
validateResults();
diff --git a/spec/javascripts/test_bundle.js b/spec/javascripts/test_bundle.js
index 50741e249ca..ce453d7c483 100644
--- a/spec/javascripts/test_bundle.js
+++ b/spec/javascripts/test_bundle.js
@@ -3,6 +3,7 @@
*/
import $ from 'jquery';
+import 'core-js/features/set-immediate';
import 'vendor/jasmine-jquery';
import '~/commons';
import Vue from 'vue';