summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeroen van Baarsen <jeroenvanbaarsen@gmail.com>2014-12-13 20:09:26 +0100
committerJeroen van Baarsen <jeroenvanbaarsen@gmail.com>2014-12-13 20:09:26 +0100
commit0cfca15292570197ec08bc9aa2bd550a0bcefc2d (patch)
tree7c8e2dc60ac418a53e3c2ffb83848bccbd4d2b25
parent2497273030e80bd7e4f891c7500901c0a38abea1 (diff)
downloadgitlab-ce-0cfca15292570197ec08bc9aa2bd550a0bcefc2d.tar.gz
Added process for green tests
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-rw-r--r--PROCESS.md7
1 files changed, 7 insertions, 0 deletions
diff --git a/PROCESS.md b/PROCESS.md
index 1dd28d6b670..310b98c9324 100644
--- a/PROCESS.md
+++ b/PROCESS.md
@@ -104,3 +104,10 @@ This merge request has been closed because a request for more information has no
### Accepting merge requests
Is there a request on [the feature request forum](http://feedback.gitlab.com/forums/176466-general) that is similar to this? If so, can you make a comment with a link to it? Please be aware that new functionality that is not marked [accepting merge/pull requests](http://feedback.gitlab.com/forums/176466-general/status/796455) on the forum might not make it into GitLab. You might be asked to make changes and even after implementing them your feature might still be declined. If you want to reduce the chance of this happening please have a discussion in the forum first.
+
+### Only accepting merge requests with green tests
+
+We can only accept a merge requests if all the tests are green, can you please
+make sure the tests of this merge requests are green? If the failing test has
+nothing do to with your merge request, you might want to rebase with master to
+see if that makes the tests green again.