diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2018-11-21 19:41:52 +0100 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2018-11-26 09:39:42 -0600 |
| commit | 87d1e865f57fbaa73f44ac196ec712ce2224e7e7 (patch) | |
| tree | 6c0bfc519ab7cffe875b3b22a96e7022c6b979c8 | |
| parent | ee17268690eba03a3f5e7086f0a679f815a84888 (diff) | |
| download | gitlab-ce-87d1e865f57fbaa73f44ac196ec712ce2224e7e7.tar.gz | |
Use have_link over have_content for GPG feature
It's more semantically accurate for what we're verifying.
| -rw-r--r-- | spec/features/signed_commits_spec.rb | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/spec/features/signed_commits_spec.rb b/spec/features/signed_commits_spec.rb index 10b6900799f..e2b3444272e 100644 --- a/spec/features/signed_commits_spec.rb +++ b/spec/features/signed_commits_spec.rb @@ -15,8 +15,8 @@ describe 'GPG signed commits' do visit project_commit_path(project, ref) - expect(page).to have_content 'Unverified' - expect(page).not_to have_content 'Verified' + expect(page).to have_link 'Unverified' + expect(page).not_to have_link 'Verified' # user changes his email which makes the gpg key verified perform_enqueued_jobs do @@ -26,8 +26,8 @@ describe 'GPG signed commits' do visit project_commit_path(project, ref) - expect(page).not_to have_content 'Unverified' - expect(page).to have_content 'Verified' + expect(page).not_to have_link 'Unverified' + expect(page).to have_link 'Verified' end it 'changes from unverified to verified when the user adds the missing gpg key' do @@ -36,8 +36,8 @@ describe 'GPG signed commits' do visit project_commit_path(project, ref) - expect(page).to have_content 'Unverified' - expect(page).not_to have_content 'Verified' + expect(page).to have_link 'Unverified' + expect(page).not_to have_link 'Verified' # user adds the gpg key which makes the signature valid perform_enqueued_jobs do @@ -46,8 +46,8 @@ describe 'GPG signed commits' do visit project_commit_path(project, ref) - expect(page).not_to have_content 'Unverified' - expect(page).to have_content 'Verified' + expect(page).not_to have_link 'Unverified' + expect(page).to have_link 'Verified' end context 'shows popover badges', :js do @@ -136,7 +136,7 @@ describe 'GPG signed commits' do visit project_commit_path(project, GpgHelpers::SIGNED_AND_AUTHORED_SHA) # wait for the signature to get generated - expect(page).to have_content 'Verified' + expect(page).to have_link 'Verified' user_1.destroy! |