diff options
| author | Winnie Hellmann <winnie@gitlab.com> | 2019-05-30 07:31:42 +0000 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2019-05-30 07:31:42 +0000 |
| commit | ed5ecec1a46a674d72703c9ac1b79f65fd57cef5 (patch) | |
| tree | 4da2117bfde2d871c74a6000f2feaf1d9553f269 | |
| parent | 101733b5672b1eb1587985c56f94555c964f0164 (diff) | |
| download | gitlab-ce-ed5ecec1a46a674d72703c9ac1b79f65fd57cef5.tar.gz | |
Extract clearDetailIssue() to issue boards store
4 files changed, 16 insertions, 2 deletions
diff --git a/app/assets/javascripts/boards/components/sidebar/remove_issue.vue b/app/assets/javascripts/boards/components/sidebar/remove_issue.vue index a2b8a0af236..4ab2b17301f 100644 --- a/app/assets/javascripts/boards/components/sidebar/remove_issue.vue +++ b/app/assets/javascripts/boards/components/sidebar/remove_issue.vue @@ -48,7 +48,7 @@ export default Vue.extend({ list.removeIssue(issue); }); - boardsStore.detail.issue = {}; + boardsStore.clearDetailIssue(); }, /** * Build the default patch request. diff --git a/app/assets/javascripts/boards/index.js b/app/assets/javascripts/boards/index.js index 4995a8d9367..25f686e4b28 100644 --- a/app/assets/javascripts/boards/index.js +++ b/app/assets/javascripts/boards/index.js @@ -167,7 +167,7 @@ export default () => { boardsStore.detail.issue = newIssue; }, clearDetailIssue() { - boardsStore.detail.issue = {}; + boardsStore.clearDetailIssue(); }, toggleSubscription(id) { const { issue } = boardsStore.detail; diff --git a/app/assets/javascripts/boards/stores/boards_store.js b/app/assets/javascripts/boards/stores/boards_store.js index 70861fbf2b3..fef16c11c0d 100644 --- a/app/assets/javascripts/boards/stores/boards_store.js +++ b/app/assets/javascripts/boards/stores/boards_store.js @@ -188,6 +188,10 @@ const boardsStore = { updateFiltersUrl() { window.history.pushState(null, null, `?${this.filter.path}`); }, + + clearDetailIssue() { + this.detail.issue = {}; + }, }; BoardsStoreEE.initEESpecific(boardsStore); diff --git a/spec/javascripts/boards/boards_store_spec.js b/spec/javascripts/boards/boards_store_spec.js index 22f192bc7f3..26e851b5641 100644 --- a/spec/javascripts/boards/boards_store_spec.js +++ b/spec/javascripts/boards/boards_store_spec.js @@ -268,4 +268,14 @@ describe('Store', () => { }); }); }); + + describe('clearDetailIssue', () => { + it('resets issue details', () => { + boardsStore.detail.issue = 'something'; + + boardsStore.clearDetailIssue(); + + expect(boardsStore.detail.issue).toEqual({}); + }); + }); }); |