diff options
author | Peter Leitzen <pl@neopoly.de> | 2018-08-01 16:54:13 +0200 |
---|---|---|
committer | Peter Leitzen <pl@neopoly.de> | 2018-08-10 16:45:11 +0200 |
commit | 56ce46674f93e35b2ed54771c1a54dde21f38685 (patch) | |
tree | 9e1948131b383b4afea7987bb19a1b89d1118f3f | |
parent | fbd0f162524b6dd875097f76e1175a55dba5f3f6 (diff) | |
download | gitlab-ce-56ce46674f93e35b2ed54771c1a54dde21f38685.tar.gz |
You cannot `/award` a Commit
-rw-r--r-- | app/services/quick_actions/interpret_service.rb | 3 | ||||
-rw-r--r-- | spec/services/quick_actions/interpret_service_spec.rb | 6 |
2 files changed, 8 insertions, 1 deletions
diff --git a/app/services/quick_actions/interpret_service.rb b/app/services/quick_actions/interpret_service.rb index d84da989924..eb71f04c164 100644 --- a/app/services/quick_actions/interpret_service.rb +++ b/app/services/quick_actions/interpret_service.rb @@ -393,7 +393,8 @@ module QuickActions end params ':emoji:' condition do - issuable.persisted? + issuable.is_a?(Issuable) && + issuable.persisted? end parse_params do |emoji_param| match = emoji_param.match(Banzai::Filter::EmojiFilter.emoji_pattern) diff --git a/spec/services/quick_actions/interpret_service_spec.rb b/spec/services/quick_actions/interpret_service_spec.rb index be209c41c0f..af1064d032d 100644 --- a/spec/services/quick_actions/interpret_service_spec.rb +++ b/spec/services/quick_actions/interpret_service_spec.rb @@ -980,6 +980,12 @@ describe QuickActions::InterpretService do let(:issuable) { issue } end end + + context 'if issuable is a Commit' do + let(:content) { '/award :100:' } + let(:issuable) { commit } + it_behaves_like 'empty command' + end end context '/shrug command' do |