summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Leitzen <pl@neopoly.de>2018-07-21 12:24:07 +0200
committerPeter Leitzen <pl@neopoly.de>2018-08-10 16:45:11 +0200
commita892b2354c953d62445a5cf9ac747ee166256c66 (patch)
tree7857e2126d2b7935e3decf3dfdd6cd1ecd67f9be
parentcc1aecdb4f3b3950f50ae53ae842f6b8912f401c (diff)
downloadgitlab-ce-a892b2354c953d62445a5cf9ac747ee166256c66.tar.gz
Tag a commit via `/tag 1.2.3 message`
-rw-r--r--app/services/commits/update_service.rb21
-rw-r--r--spec/services/commits/update_service_spec.rb47
2 files changed, 67 insertions, 1 deletions
diff --git a/app/services/commits/update_service.rb b/app/services/commits/update_service.rb
index 9cd5ddc7f91..7ec678ff1cf 100644
--- a/app/services/commits/update_service.rb
+++ b/app/services/commits/update_service.rb
@@ -3,7 +3,26 @@
module Commits
class UpdateService < BaseService
def execute(commit)
- # TODO authorize user
+ tag_commit(commit)
+ end
+
+ private
+
+ def tag_commit(commit)
+ # TODO authorize
+ return unless params[:tag_name]
+
+ tag_name = params[:tag_name]
+ message = params[:tag_message]
+ release_description = nil
+
+ result = Tags::CreateService
+ .new(commit.project, current_user)
+ .execute(tag_name, commit.sha, message, release_description)
+
+ if result[:status]
+ commit
+ end
end
end
end
diff --git a/spec/services/commits/update_service_spec.rb b/spec/services/commits/update_service_spec.rb
new file mode 100644
index 00000000000..cfca3a85236
--- /dev/null
+++ b/spec/services/commits/update_service_spec.rb
@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Commits::UpdateService do
+ let(:project) { create(:project, :repository) }
+ let(:user) { create(:user) }
+
+ let(:commit) { create(:commit, project: project) }
+
+ before do
+ project.add_maintainer(user)
+ end
+
+ describe 'execute' do
+ let(:service) { described_class.new(project, user, opts) }
+
+ context 'valid params' do
+ let(:opts) do
+ {
+ tag_name: '1.2.3',
+ tag_message: 'Release'
+ }
+ end
+
+ it 'tags a commit' do
+ tag_stub = instance_double(Tags::CreateService)
+ allow(Tags::CreateService).to receive(:new).and_return(tag_stub)
+ allow(tag_stub).to receive(:execute)
+ .with(opts[:tag_name], commit.sha, opts[:tag_message], nil)
+ .and_return({ status: :success })
+
+ service.execute(commit)
+ end
+ end
+
+ context 'invalid params' do
+ let(:opts) do
+ {}
+ end
+
+ it 'does not call the tag create service' do
+ expect(Tags::CreateService).not_to receive(:new)
+
+ service.execute(commit)
+ end
+ end
+ end
+end