diff options
| author | Rémy Coutable <remy@rymai.me> | 2019-01-17 18:53:09 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-01-17 18:56:41 +0100 |
| commit | a4f73241708a777117637d7671584bd255638768 (patch) | |
| tree | 8b4ba767c39e8aee49a1e363d2ef212e1fb94cac | |
| parent | daae58d280ab61fce24d5353dd7f2f95be7eb3cc (diff) | |
| download | gitlab-ce-a4f73241708a777117637d7671584bd255638768.tar.gz | |
[Review Apps] Don't exit when dependable job fails
The function that retrieves the dependable job is pretty basic and
retrieves the first job found with the matching name, but this job can
be failed but then successfully retried. In that case, we would exit the
depending job even though the dependable job actually succeeded (the
second time). Let's simplify things, be optimistic and continue with the
depending job even if the dependable job fails.
That reverts to the original behavior.
Signed-off-by: Rémy Coutable <remy@rymai.me>
| -rwxr-xr-x | scripts/review_apps/review-apps.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh index 4e1dbff7b80..1ee6f502b8e 100755 --- a/scripts/review_apps/review-apps.sh +++ b/scripts/review_apps/review-apps.sh @@ -346,7 +346,6 @@ function wait_for_job_to_be_done() { if [[ "${job_status}" == "failed" ]]; then echo "The '${job_name}' failed." - exit 1 elif [[ "${job_status}" == "manual" ]]; then echo "The '${job_name}' is manual." else |