diff options
| author | Shinya Maeda <shinya@gitlab.com> | 2018-07-25 16:24:05 +0900 |
|---|---|---|
| committer | Shinya Maeda <shinya@gitlab.com> | 2018-07-25 16:24:05 +0900 |
| commit | 9cabd787fc392c7a442cd8b2de798da36c8b67bc (patch) | |
| tree | fd66e0d687775c8c8c23892885d045122aa26442 | |
| parent | 21de18bf9fecdfadadb80c5a071ff5d7af6ff524 (diff) | |
| download | gitlab-ce-9cabd787fc392c7a442cd8b2de798da36c8b67bc.tar.gz | |
Fix N+1 problem at collect_test_reports
| -rw-r--r-- | app/models/ci/build.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb index fcfc3120757..3490ea6fe2a 100644 --- a/app/models/ci/build.rb +++ b/app/models/ci/build.rb @@ -616,9 +616,9 @@ module Ci def collect_test_reports(test_reports) test_reports.get_suite(group_name).tap do |test_suite| - job_artifacts.test_reports.each do |report_artifact| - report_artifact.each_blob do |blob, name| - "Gitlab::Ci::Parsers::#{report_artifact.file_type.capitalize}Parser".constantize + Ci::JobArtifact::TEST_REPORT_FILE_TYPES.each do |file_type| + public_send("job_artifacts_#{file_type}").each_blob do |blob, name| + "Gitlab::Ci::Parsers::#{file_type.capitalize}Parser".constantize .new(blob).parse!(test_suite) end end |