diff options
| author | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-18 18:52:11 -0500 |
|---|---|---|
| committer | Alfredo Sumaran <alfredo@gitlab.com> | 2016-11-21 13:57:10 -0500 |
| commit | 283134a7def2ace2c3da5aa36db6bc29e46e8bed (patch) | |
| tree | 5dc990dee0f722f5e7452d3a551bb74f0ab31f06 | |
| parent | 4dbcf6723eaa8d89c2f4e36d4e8a6f2bc76fa1d1 (diff) | |
| download | gitlab-ce-283134a7def2ace2c3da5aa36db6bc29e46e8bed.tar.gz | |
Remove unnecesary empty dialog
3 files changed, 0 insertions, 10 deletions
diff --git a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js index 9e5a40211ab..bb67dd429e2 100644 --- a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js +++ b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js @@ -2,7 +2,6 @@ //= require_tree . $(() => { - const EMPTY_DIALOG_COOKIE = 'ca_empty_dialog_dismissed'; const OVERVIEW_DIALOG_COOKIE = 'ca_overview_dialog_dismissed'; const cycleAnalyticsEl = document.querySelector('#cycle-analytics'); const cycleAnalyticsStore = gl.cycleAnalytics.CycleAnalyticsStore; @@ -20,7 +19,6 @@ $(() => { isEmptyStage: false, hasError: false, startDate: 30, - isEmptyDialogDismissed: Cookies.get(EMPTY_DIALOG_COOKIE), isOverviewDialogDismissed: Cookies.get(OVERVIEW_DIALOG_COOKIE), }, computed: { @@ -104,10 +102,6 @@ $(() => { this.isLoadingStage = false; }); }, - dismissEmptyDialog() { - this.isEmptyDialogDismissed = true; - Cookies.set(EMPTY_DIALOG_COOKIE, '1'); - }, dismissOverviewDialog() { this.isOverviewDialogDismissed = true; Cookies.set(OVERVIEW_DIALOG_COOKIE, '1'); diff --git a/app/views/projects/cycle_analytics/_empty_cycle_analytics.html.haml b/app/views/projects/cycle_analytics/_empty_cycle_analytics.html.haml deleted file mode 100644 index 2a0352a3e19..00000000000 --- a/app/views/projects/cycle_analytics/_empty_cycle_analytics.html.haml +++ /dev/null @@ -1,2 +0,0 @@ -%p There is nothing happened -= icon("times", class: "dismiss-icon", "@click" => "dismissEmptyDialog()") diff --git a/app/views/projects/cycle_analytics/show.html.haml b/app/views/projects/cycle_analytics/show.html.haml index b9676794f44..50255fe7a29 100644 --- a/app/views/projects/cycle_analytics/show.html.haml +++ b/app/views/projects/cycle_analytics/show.html.haml @@ -10,8 +10,6 @@ - content_for :page_specific_javascripts do = page_specific_javascript_tag("cycle_analytics/cycle_analytics_bundle.js") #cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } } - .empty-dialog-message{ "v-if" => "!isEmptyDialogDismissed" } - = render partial: "empty_cycle_analytics" .bordered-box.landing.content-block{"v-if" => "!isOverviewDialogDismissed"} = icon("times", class: "dismiss-icon", "@click" => "dismissOverviewDialog()") .row |