diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-10-13 09:53:30 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-10-13 09:53:30 +0000 |
| commit | 9d44ef2b3c3781044f7663623a5233a1ebc0dc0e (patch) | |
| tree | fb59fe311e9f6ce48139ce417074f2f269027f82 | |
| parent | 1524832f906d9310beb2924ef455f66d2b61d9c1 (diff) | |
| parent | 31c41a8fe1ef67347e5bcfdb97ff15a079976945 (diff) | |
| download | gitlab-ce-9d44ef2b3c3781044f7663623a5233a1ebc0dc0e.tar.gz | |
Merge branch 'fix-some-specs' into 'master'
Improve appearance_spec and deploy_key_spec
In appearance_spec.rb we can use build instead create record in db. In deploy_key_spec.rb we can remove unused code.
See merge request !6819
| -rw-r--r-- | spec/models/appearance_spec.rb | 2 | ||||
| -rw-r--r-- | spec/models/deploy_key_spec.rb | 3 |
2 files changed, 1 insertions, 4 deletions
diff --git a/spec/models/appearance_spec.rb b/spec/models/appearance_spec.rb index c5658bd26e1..0b72a2f979b 100644 --- a/spec/models/appearance_spec.rb +++ b/spec/models/appearance_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' RSpec.describe Appearance, type: :model do - subject { create(:appearance) } + subject { build(:appearance) } it { is_expected.to be_valid } diff --git a/spec/models/deploy_key_spec.rb b/spec/models/deploy_key_spec.rb index 6a90598a629..93623e8e99b 100644 --- a/spec/models/deploy_key_spec.rb +++ b/spec/models/deploy_key_spec.rb @@ -1,9 +1,6 @@ require 'spec_helper' describe DeployKey, models: true do - let(:project) { create(:project) } - let(:deploy_key) { create(:deploy_key, projects: [project]) } - describe "Associations" do it { is_expected.to have_many(:deploy_keys_projects) } it { is_expected.to have_many(:projects) } |