diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-05-15 13:34:49 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-05-15 14:43:39 +0200 |
commit | 7186f0de657f510e27e24b6845f99ded158118af (patch) | |
tree | 993b772c8015a8f367c65c5d9c6e6eaf123ee43e | |
parent | d134c0fb70eb9330680872edefa8841641931018 (diff) | |
download | gitlab-ce-7186f0de657f510e27e24b6845f99ded158118af.tar.gz |
Improve testing best practices guidelinesbackstage/gb/improve-fast-specs-helper
It mentions that explicitly defining dependencies in sources is
preferred over defining such dependencies only in spec files.
-rw-r--r-- | doc/development/testing_guide/best_practices.md | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 5aa2068b495..c4d350e3676 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -141,20 +141,14 @@ dependencies. `fast_spec_helper` also loads all ActiveSupport extensions, including core extensions that are commonly used in the Rails environment. Note that in some cases, you might still have to load some dependencies using -`require_dependency` in your `*_spec.rb` file, like when a code is using gems. +`require_dependency` when a code is using gems or a dependency is not located +in `lib/`. For example, if you want to test your code that is calling the `Gitlab::UntrustedRegexp` class, which under the hood uses `re2` library, you -should be able to define a test using follow code snippet. - -```ruby -require 'fast_spec_helper' -require_dependency 're2' - -describe Gitlab::MyModule::MyClass do - # ... -end -``` +should either add `require_dependency 're2'` to files in your library that +need `re2` gem, to make this requirement explicit, or you can add it to the +spec itself, but the former is preferred. It takes around one second to load tests that are using `fast_spec_helper` instead of 30+ seconds in case of a regular `spec_helper`. |