diff options
| author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-12-15 20:03:35 +0000 |
|---|---|---|
| committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-12-15 20:03:35 +0000 |
| commit | 38377405601c272bde836b6be8e93c33315d78f4 (patch) | |
| tree | 1ec5890f375154d11aefba4ddb1fdabf3f1112fa | |
| parent | f3c2855f8e2c5cffe5548ff95dbeec6fe56446f0 (diff) | |
| parent | b3bd9abceaaccafe0462220ffe4bf611c784e5c0 (diff) | |
| download | gitlab-ce-38377405601c272bde836b6be8e93c33315d78f4.tar.gz | |
Merge branch '24824-dropdown-items-focus' into 'master'
24824 Add focus state to dropdowns
## What does this MR do?
Adds focus state to dropdown items to increase accessibility.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #24824
See merge request !7885
| -rw-r--r-- | app/assets/stylesheets/framework/dropdowns.scss | 1 | ||||
| -rw-r--r-- | changelogs/unreleased/24824-dropdown-items-focus.yml | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/app/assets/stylesheets/framework/dropdowns.scss b/app/assets/stylesheets/framework/dropdowns.scss index ecd540793d0..11adf2568a1 100644 --- a/app/assets/stylesheets/framework/dropdowns.scss +++ b/app/assets/stylesheets/framework/dropdowns.scss @@ -188,7 +188,6 @@ &.is-focused { background-color: $dropdown-link-hover-bg; text-decoration: none; - outline: 0; } &.dropdown-menu-empty-link { diff --git a/changelogs/unreleased/24824-dropdown-items-focus.yml b/changelogs/unreleased/24824-dropdown-items-focus.yml new file mode 100644 index 00000000000..66970c2a9a5 --- /dev/null +++ b/changelogs/unreleased/24824-dropdown-items-focus.yml @@ -0,0 +1,4 @@ +--- +title: Add focus state to dropdown items +merge_request: +author: |