summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatija Čupić <matteeyah@gmail.com>2018-03-24 11:46:04 +0100
committerMatija Čupić <matteeyah@gmail.com>2018-03-24 11:46:04 +0100
commitd696194f8f80dd6fe4feb9ec7bb42a29ab9e98f1 (patch)
treecddf3cfda961cdf70a541d2d80a78f33ccade451
parent18bce8fcfeaaeeda5aea37f21adedcdc49dd4147 (diff)
downloadgitlab-ce-d696194f8f80dd6fe4feb9ec7bb42a29ab9e98f1.tar.gz
Add illustrations to build statuses
-rw-r--r--lib/gitlab/ci/status/canceled.rb4
-rw-r--r--lib/gitlab/ci/status/core.rb4
-rw-r--r--lib/gitlab/ci/status/created.rb4
-rw-r--r--lib/gitlab/ci/status/manual.rb4
-rw-r--r--lib/gitlab/ci/status/pending.rb4
-rw-r--r--lib/gitlab/ci/status/skipped.rb4
-rw-r--r--spec/lib/gitlab/ci/status/build/factory_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/status/canceled_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/status/created_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/status/manual_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/status/pending_spec.rb4
-rw-r--r--spec/lib/gitlab/ci/status/skipped_spec.rb4
12 files changed, 48 insertions, 0 deletions
diff --git a/lib/gitlab/ci/status/canceled.rb b/lib/gitlab/ci/status/canceled.rb
index e6195a60d4f..9a25375678d 100644
--- a/lib/gitlab/ci/status/canceled.rb
+++ b/lib/gitlab/ci/status/canceled.rb
@@ -17,6 +17,10 @@ module Gitlab
def favicon
'favicon_status_canceled'
end
+
+ def illustration
+ 'canceled-job_empty'
+ end
end
end
end
diff --git a/lib/gitlab/ci/status/core.rb b/lib/gitlab/ci/status/core.rb
index d4fd83b93f8..89fb9a0b7bc 100644
--- a/lib/gitlab/ci/status/core.rb
+++ b/lib/gitlab/ci/status/core.rb
@@ -22,6 +22,10 @@ module Gitlab
raise NotImplementedError
end
+ def illustration
+ raise NotImplementedError
+ end
+
def label
raise NotImplementedError
end
diff --git a/lib/gitlab/ci/status/created.rb b/lib/gitlab/ci/status/created.rb
index 846f00b83dd..033ecbe9380 100644
--- a/lib/gitlab/ci/status/created.rb
+++ b/lib/gitlab/ci/status/created.rb
@@ -17,6 +17,10 @@ module Gitlab
def favicon
'favicon_status_created'
end
+
+ def illustration
+ 'job_not_triggered'
+ end
end
end
end
diff --git a/lib/gitlab/ci/status/manual.rb b/lib/gitlab/ci/status/manual.rb
index fc387e2fd25..92c449e2c63 100644
--- a/lib/gitlab/ci/status/manual.rb
+++ b/lib/gitlab/ci/status/manual.rb
@@ -17,6 +17,10 @@ module Gitlab
def favicon
'favicon_status_manual'
end
+
+ def illustration
+ 'manual_action'
+ end
end
end
end
diff --git a/lib/gitlab/ci/status/pending.rb b/lib/gitlab/ci/status/pending.rb
index 6780780db32..63c0b5b501f 100644
--- a/lib/gitlab/ci/status/pending.rb
+++ b/lib/gitlab/ci/status/pending.rb
@@ -17,6 +17,10 @@ module Gitlab
def favicon
'favicon_status_pending'
end
+
+ def illustration
+ 'pending_job_empty'
+ end
end
end
end
diff --git a/lib/gitlab/ci/status/skipped.rb b/lib/gitlab/ci/status/skipped.rb
index 0dbdc4de426..5dbe2847344 100644
--- a/lib/gitlab/ci/status/skipped.rb
+++ b/lib/gitlab/ci/status/skipped.rb
@@ -17,6 +17,10 @@ module Gitlab
def favicon
'favicon_status_skipped'
end
+
+ def illustration
+ 'skipped-job_empty'
+ end
end
end
end
diff --git a/spec/lib/gitlab/ci/status/build/factory_spec.rb b/spec/lib/gitlab/ci/status/build/factory_spec.rb
index d196bc6a4c2..04b718c5897 100644
--- a/spec/lib/gitlab/ci/status/build/factory_spec.rb
+++ b/spec/lib/gitlab/ci/status/build/factory_spec.rb
@@ -115,6 +115,7 @@ describe Gitlab::Ci::Status::Build::Factory do
expect(status.text).to eq 'canceled'
expect(status.icon).to eq 'status_canceled'
expect(status.favicon).to eq 'favicon_status_canceled'
+ expect(status.illustration).to eq 'canceled-job_empty'
expect(status.label).to eq 'canceled'
expect(status).to have_details
expect(status).to have_action
@@ -167,6 +168,7 @@ describe Gitlab::Ci::Status::Build::Factory do
expect(status.text).to eq 'pending'
expect(status.icon).to eq 'status_pending'
expect(status.favicon).to eq 'favicon_status_pending'
+ expect(status.illustration).to eq 'pending_job_empty'
expect(status.label).to eq 'pending'
expect(status).to have_details
expect(status).to have_action
@@ -192,6 +194,7 @@ describe Gitlab::Ci::Status::Build::Factory do
expect(status.text).to eq 'skipped'
expect(status.icon).to eq 'status_skipped'
expect(status.favicon).to eq 'favicon_status_skipped'
+ expect(status.illustration).to eq 'skipped-job_empty'
expect(status.label).to eq 'skipped'
expect(status).to have_details
expect(status).not_to have_action
@@ -221,6 +224,7 @@ describe Gitlab::Ci::Status::Build::Factory do
expect(status.group).to eq 'manual'
expect(status.icon).to eq 'status_manual'
expect(status.favicon).to eq 'favicon_status_manual'
+ expect(status.illustration).to eq 'manual_action'
expect(status.label).to include 'manual play action'
expect(status).to have_details
expect(status.action_path).to include 'play'
diff --git a/spec/lib/gitlab/ci/status/canceled_spec.rb b/spec/lib/gitlab/ci/status/canceled_spec.rb
index dc74d7e28c5..fc1d9e726ab 100644
--- a/spec/lib/gitlab/ci/status/canceled_spec.rb
+++ b/spec/lib/gitlab/ci/status/canceled_spec.rb
@@ -21,6 +21,10 @@ describe Gitlab::Ci::Status::Canceled do
it { expect(subject.favicon).to eq 'favicon_status_canceled' }
end
+ describe '#illustration' do
+ it { expect(subject.illustration).to eq 'canceled-job_empty' }
+ end
+
describe '#group' do
it { expect(subject.group).to eq 'canceled' }
end
diff --git a/spec/lib/gitlab/ci/status/created_spec.rb b/spec/lib/gitlab/ci/status/created_spec.rb
index ce4333f2aca..f7e3b0d8f1a 100644
--- a/spec/lib/gitlab/ci/status/created_spec.rb
+++ b/spec/lib/gitlab/ci/status/created_spec.rb
@@ -21,6 +21,10 @@ describe Gitlab::Ci::Status::Created do
it { expect(subject.favicon).to eq 'favicon_status_created' }
end
+ describe '#illustration' do
+ it { expect(subject.illustration).to eq 'job_not_triggered' }
+ end
+
describe '#group' do
it { expect(subject.group).to eq 'created' }
end
diff --git a/spec/lib/gitlab/ci/status/manual_spec.rb b/spec/lib/gitlab/ci/status/manual_spec.rb
index 0463f2e1aff..161c4774ff3 100644
--- a/spec/lib/gitlab/ci/status/manual_spec.rb
+++ b/spec/lib/gitlab/ci/status/manual_spec.rb
@@ -21,6 +21,10 @@ describe Gitlab::Ci::Status::Manual do
it { expect(subject.favicon).to eq 'favicon_status_manual' }
end
+ describe '#illustration' do
+ it { expect(subject.illustration).to eq 'manual_action' }
+ end
+
describe '#group' do
it { expect(subject.group).to eq 'manual' }
end
diff --git a/spec/lib/gitlab/ci/status/pending_spec.rb b/spec/lib/gitlab/ci/status/pending_spec.rb
index 0e25358dd8a..92349308842 100644
--- a/spec/lib/gitlab/ci/status/pending_spec.rb
+++ b/spec/lib/gitlab/ci/status/pending_spec.rb
@@ -21,6 +21,10 @@ describe Gitlab::Ci::Status::Pending do
it { expect(subject.favicon).to eq 'favicon_status_pending' }
end
+ describe '#illustration' do
+ it { expect(subject.illustration).to eq 'pending_job_empty' }
+ end
+
describe '#group' do
it { expect(subject.group).to eq 'pending' }
end
diff --git a/spec/lib/gitlab/ci/status/skipped_spec.rb b/spec/lib/gitlab/ci/status/skipped_spec.rb
index 63694ca0ea6..993490c6d4e 100644
--- a/spec/lib/gitlab/ci/status/skipped_spec.rb
+++ b/spec/lib/gitlab/ci/status/skipped_spec.rb
@@ -21,6 +21,10 @@ describe Gitlab::Ci::Status::Skipped do
it { expect(subject.favicon).to eq 'favicon_status_skipped' }
end
+ describe '#illustration' do
+ it { expect(subject.illustration).to eq 'skipped-job_empty' }
+ end
+
describe '#group' do
it { expect(subject.group).to eq 'skipped' }
end