summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDennis Tang <dtang@gitlab.com>2018-05-09 15:05:44 +0200
committerDennis Tang <dtang@gitlab.com>2018-05-09 15:05:44 +0200
commite73da567c1d9a8b31622d9cca39a7a833527f21e (patch)
tree24976a6ceba2fc031b8c0ed9e2327d982640b97a
parent4b752e2e17028fb005fde0189c872d3848e73197 (diff)
downloadgitlab-ce-e73da567c1d9a8b31622d9cca39a7a833527f21e.tar.gz
clean up enableSubmit check
-rw-r--r--app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue5
1 files changed, 4 insertions, 1 deletions
diff --git a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue
index 2ab1e48488c..5e208bec9e8 100644
--- a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue
+++ b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue
@@ -44,6 +44,9 @@ export default {
computed: {
...mapState(['selectedProject', 'selectedZone', 'selectedMachineType', 'machineTypes']),
...mapGetters(['hasProject', 'hasZone', 'hasMachineType']),
+ allDropdownsSelected() {
+ return this.hasProject && this.hasZone && this.hasMachineType;
+ },
isDisabled() {
return !this.selectedProject || !this.selectedZone;
},
@@ -107,7 +110,7 @@ export default {
});
},
enableSubmit() {
- if (this.hasProject && this.hasZone && this.hasMachineType) {
+ if (this.allDropdownsSelected) {
const submitButtonEl = document.querySelector('.js-gke-cluster-creation-submit');
if (submitButtonEl) {