diff options
author | Phil Hughes <me@iamphill.com> | 2018-11-12 08:51:06 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-11-12 14:42:22 +0000 |
commit | eaca2033d5145d8f679ecfe948a2d4ed909088ea (patch) | |
tree | d039f99abe07aa9e33ffee44f11af11934d17660 | |
parent | 2e690c8208e9da5e7152e77cd77efdade5260be1 (diff) | |
download | gitlab-ce-eaca2033d5145d8f679ecfe948a2d4ed909088ea.tar.gz |
Changed diff tree filtering to path
Previously it was using name which could make it hard
to filter for the file you want in a certain folder.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53781
-rw-r--r-- | app/assets/javascripts/diffs/components/tree_list.vue | 2 | ||||
-rw-r--r-- | changelogs/unreleased/mr-tree-filter-path-name.yml | 5 | ||||
-rw-r--r-- | spec/javascripts/diffs/components/tree_list_spec.js | 2 |
3 files changed, 7 insertions, 2 deletions
diff --git a/app/assets/javascripts/diffs/components/tree_list.vue b/app/assets/javascripts/diffs/components/tree_list.vue index 91052b303a6..ff1eb23cea3 100644 --- a/app/assets/javascripts/diffs/components/tree_list.vue +++ b/app/assets/javascripts/diffs/components/tree_list.vue @@ -35,7 +35,7 @@ export default { if (search === '') return this.renderTreeList ? this.tree : this.allBlobs; - return this.allBlobs.filter(f => f.name.toLowerCase().indexOf(search) >= 0); + return this.allBlobs.filter(f => f.path.toLowerCase().indexOf(search) >= 0); }, rowDisplayTextKey() { if (this.renderTreeList && this.search.trim() === '') { diff --git a/changelogs/unreleased/mr-tree-filter-path-name.yml b/changelogs/unreleased/mr-tree-filter-path-name.yml new file mode 100644 index 00000000000..152f8a67337 --- /dev/null +++ b/changelogs/unreleased/mr-tree-filter-path-name.yml @@ -0,0 +1,5 @@ +--- +title: Changed merge request filtering to be by path instead of name +merge_request: +author: +type: changed diff --git a/spec/javascripts/diffs/components/tree_list_spec.js b/spec/javascripts/diffs/components/tree_list_spec.js index fc94d0bab5b..a0b380adfd6 100644 --- a/spec/javascripts/diffs/components/tree_list_spec.js +++ b/spec/javascripts/diffs/components/tree_list_spec.js @@ -81,7 +81,7 @@ describe('Diffs tree list component', () => { }); it('filters tree list to blobs matching search', done => { - vm.search = 'index'; + vm.search = 'app/index'; vm.$nextTick(() => { expect(vm.$el.querySelectorAll('.file-row').length).toBe(1); |