Fix tests for initial status

3 files changed, 20 insertions, 2 deletions

diff --git a/app/models/clusters/applications/helm.rb b/app/models/clusters/applications/helm.rb
index 0bbe5219715..7ea84841118 100644
--- a/app/models/clusters/applications/helm.rb
+++ b/app/models/clusters/applications/helm.rb
@@ -18,6 +18,8 @@ module Clusters
       end
 
       def set_initial_status
+        return unless not_installable?
+
         self.status = 'installable' if cluster&.platform_kubernetes_active?
       end
 
diff --git a/spec/factories/clusters/applications/helm.rb b/spec/factories/clusters/applications/helm.rb
index 23818f19edf..a0c874b103b 100644
--- a/spec/factories/clusters/applications/helm.rb
+++ b/spec/factories/clusters/applications/helm.rb
@@ -2,6 +2,10 @@ FactoryGirl.define do
   factory :cluster_applications_helm, class: Clusters::Applications::Helm do
     cluster factory: %i(cluster provided_by_gcp)
 
+    trait :not_installable do
+      status -2
+    end
+
     trait :installable do
       status 0
     end
diff --git a/spec/models/clusters/applications/helm_spec.rb b/spec/models/clusters/applications/helm_spec.rb
index 2b1922fdd5b..beb10bf38c9 100644
--- a/spec/models/clusters/applications/helm_spec.rb
+++ b/spec/models/clusters/applications/helm_spec.rb
@@ -21,8 +21,20 @@ describe Clusters::Applications::Helm do
   end
 
   describe '#status' do
-    it 'defaults to :installable' do
-      expect(subject.status_name).to be(:installable)
+    let(:cluster) { create(:cluster) }
+
+    subject { described_class.new(cluster: cluster) }
+
+    it 'defaults to :not_installable' do
+      expect(subject.status_name).to be(:not_installable)
+    end
+
+    context 'when platform kubernetes is defined' do
+      let(:cluster) { create(:cluster, :provided_by_gcp) }
+
+      it 'defaults to :installable' do
+        expect(subject.status_name).to be(:installable)
+      end
     end
   end