Raise exception when simplifiable ci entry incomplete

2 files changed, 17 insertions, 0 deletions

diff --git a/lib/gitlab/ci/config/entry/simplifiable.rb b/lib/gitlab/ci/config/entry/simplifiable.rb
index c26576fcbcd..0a03027736f 100644
--- a/lib/gitlab/ci/config/entry/simplifiable.rb
+++ b/lib/gitlab/ci/config/entry/simplifiable.rb
@@ -6,6 +6,10 @@ module Gitlab
           EntryStrategy = Struct.new(:name, :condition)
 
           def initialize(config, **metadata)
+            unless self.class.const_defined?(:UnknownStrategy)
+              raise ArgumentError, 'UndefinedStrategy not available!'
+            end
+
             strategy = self.class.strategies.find do |variant|
               variant.condition.call(config)
             end
diff --git a/spec/lib/gitlab/ci/config/entry/simplifiable_spec.rb b/spec/lib/gitlab/ci/config/entry/simplifiable_spec.rb
index 5f9a0625b06..395062207a3 100644
--- a/spec/lib/gitlab/ci/config/entry/simplifiable_spec.rb
+++ b/spec/lib/gitlab/ci/config/entry/simplifiable_spec.rb
@@ -72,4 +72,17 @@ describe Gitlab::Ci::Config::Entry::Simplifiable do
       end
     end
   end
+
+  context 'when a unknown strategy class is not defined' do
+    let(:entry) do
+      Class.new(described_class) do
+        strategy :String, if: -> (*) { true }
+      end
+    end
+
+    it 'raises an error when being initialized' do
+      expect { entry.new('something') }
+        .to raise_error ArgumentError, /UndefinedStrategy not available!/
+    end
+  end
 end