diff options
author | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-05-24 08:47:25 +0000 |
---|---|---|
committer | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-05-25 09:21:52 +0100 |
commit | d3655fe56f42e7d1821d783b274154a6f69c59c5 (patch) | |
tree | 20d9b7df8918e3e645d487154ea03523598d322c | |
parent | 4497ca87c488806e5df313a23f187242716727e3 (diff) | |
download | gitlab-ce-d3655fe56f42e7d1821d783b274154a6f69c59c5.tar.gz |
Add review comments to compare_spec.rb
-rw-r--r-- | spec/features/projects/compare_spec.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/spec/features/projects/compare_spec.rb b/spec/features/projects/compare_spec.rb index a8e00d434e8..4162f2579d1 100644 --- a/spec/features/projects/compare_spec.rb +++ b/spec/features/projects/compare_spec.rb @@ -52,9 +52,11 @@ describe "Compare", js: true do def select_using_dropdown(dropdown_type, selection) dropdown = find(".js-compare-#{dropdown_type}-dropdown") dropdown.find(".compare-dropdown-toggle").click + # find input before using to wait for the inputs visiblity dropdown.find('.dropdown-menu') dropdown.fill_in("Filter by Git revision", with: selection) wait_for_requests + # find before all to wait for the items visiblity dropdown.find("a[data-ref=\"#{selection}\"]", match: :first) dropdown.all("a[data-ref=\"#{selection}\"]").last.click end |