diff options
| author | Sean McGivern <sean@gitlab.com> | 2019-06-06 19:14:08 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2019-06-06 19:14:08 +0100 |
| commit | 1b2de25deeab172cabd8d74ad7fc60a4db39cbe5 (patch) | |
| tree | ea5e03f8dc70010cdd3ecb0af44f6c5bb60dc00a | |
| parent | 70a717daf9457e3400d7d519a97dc189e55685ca (diff) | |
| download | gitlab-ce-1b2de25deeab172cabd8d74ad7fc60a4db39cbe5.tar.gz | |
Don't fail the pipeline when a colon-emoji is used
A colon-emoji like :100: can be valid in the case where we're talking
about the GitLab feature that processes these into emojis. It's fine to
warn about those, but failing the pipeline is too restrictive.
| -rw-r--r-- | danger/commit_messages/Dangerfile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/danger/commit_messages/Dangerfile b/danger/commit_messages/Dangerfile index 048c539bcf9..bdb4343b1d6 100644 --- a/danger/commit_messages/Dangerfile +++ b/danger/commit_messages/Dangerfile @@ -163,10 +163,10 @@ def lint_commit(commit) end if emoji_checker.includes_emoji?(commit.message) - fail_commit( + warn_commit( commit, 'Avoid the use of Markdown Emoji such as `:+1:`. ' \ - 'These add no value to the commit message, ' \ + 'These add limited value to the commit message, ' \ 'and are displayed as plain text outside of GitLab' ) |