diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-05-15 15:53:54 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-05-15 15:53:54 +0000 |
| commit | 11b7f911bd6ea1e3dc5a1eea345c08d2d05cd41b (patch) | |
| tree | 8d176b2348025d7250885afaff4ef4abda9d600a | |
| parent | a892fc2868f2ee64e4b70082c9686cb437701746 (diff) | |
| parent | 42d191c9d6c772afcfa67f986406075337c6cc3d (diff) | |
| download | gitlab-ce-11b7f911bd6ea1e3dc5a1eea345c08d2d05cd41b.tar.gz | |
Merge branch 'y-yagi1-master-patch-17475' into 'master'
Fix link for `query_recorder.rb`
See merge request gitlab-org/gitlab-ce!18761
| -rw-r--r-- | doc/development/query_recorder.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/query_recorder.md b/doc/development/query_recorder.md index 12e90101139..26d3355e94d 100644 --- a/doc/development/query_recorder.md +++ b/doc/development/query_recorder.md @@ -2,7 +2,7 @@ QueryRecorder is a tool for detecting the [N+1 queries problem](http://guides.rubyonrails.org/active_record_querying.html#eager-loading-associations) from tests. -> Implemented in [spec/support/query_recorder.rb](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/support/query_recorder.rb) via [9c623e3e](https://gitlab.com/gitlab-org/gitlab-ce/commit/9c623e3e5d7434f2e30f7c389d13e5af4ede770a) +> Implemented in [spec/support/query_recorder.rb](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/support/helpers/query_recorder.rb) via [9c623e3e](https://gitlab.com/gitlab-org/gitlab-ce/commit/9c623e3e5d7434f2e30f7c389d13e5af4ede770a) As a rule, merge requests [should not increase query counts](merge_request_performance_guidelines.md#query-counts). If you find yourself adding something like `.includes(:author, :assignee)` to avoid having `N+1` queries, consider using QueryRecorder to enforce this with a test. Without this, a new feature which causes an additional model to be accessed will silently reintroduce the problem. |