summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEvan Read <eread@gitlab.com>2019-09-09 01:14:36 +0000
committerEvan Read <eread@gitlab.com>2019-09-09 01:14:36 +0000
commite65ddd83cc2372e5c35eeefc8383e80c95984719 (patch)
tree123903c5dfa65781daa43940f322d8b2cc181114
parent2e8cf4d5e41c50839b55f390839dd1c85581fb1c (diff)
parentf3c14d85062ee1359650e6539adba9b095073262 (diff)
downloadgitlab-ce-e65ddd83cc2372e5c35eeefc8383e80c95984719.tar.gz
Merge branch 'docs/standardise_punctuation' into 'master'
Standardised punctuation at end of sentences See merge request gitlab-org/gitlab-ce!32723
-rw-r--r--doc/development/background_migrations.md8
1 files changed, 4 insertions, 4 deletions
diff --git a/doc/development/background_migrations.md b/doc/development/background_migrations.md
index a456bbc781f..606ee431c3e 100644
--- a/doc/development/background_migrations.md
+++ b/doc/development/background_migrations.md
@@ -302,18 +302,18 @@ for more details.
## Best practices
-1. Make sure to know how much data you're dealing with
+1. Make sure to know how much data you're dealing with.
1. Make sure that background migration jobs are idempotent.
1. Make sure that tests you write are not false positives.
1. Make sure that if the data being migrated is critical and cannot be lost, the
clean-up migration also checks the final state of the data before completing.
-1. Make sure to know how much time it'll take to run all scheduled migrations
+1. Make sure to know how much time it'll take to run all scheduled migrations.
1. When migrating many columns, make sure it won't generate too many
dead tuples in the process (you may need to directly query the number of dead tuples
- and adjust the scheduling according to this piece of data)
+ and adjust the scheduling according to this piece of data).
1. Make sure to discuss the numbers with a database specialist, the migration may add
more pressure on DB than you expect (measure on staging,
- or ask someone to measure on production)
+ or ask someone to measure on production).
[migrations-readme]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/migrations/README.md
[issue-rspec-hooks]: https://gitlab.com/gitlab-org/gitlab-ce/issues/35351