summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Bajao <ebajao@gitlab.com>2019-08-23 15:50:41 +0800
committerPatrick Bajao <ebajao@gitlab.com>2019-08-30 10:40:18 +0800
commitefbc7a39da14634105596a964e530530f7178058 (patch)
treea574a8c441b789d1581d21f63707e38da175bc0d
parent615b73c739e7d9e98241ca7c8d10f465f581d27f (diff)
downloadgitlab-ce-efbc7a39da14634105596a964e530530f7178058.tar.gz
Doc: Add info about update/delete restriction
-rw-r--r--doc/api/merge_request_approvals.md8
1 files changed, 7 insertions, 1 deletions
diff --git a/doc/api/merge_request_approvals.md b/doc/api/merge_request_approvals.md
index e1aca97f3a7..e60560d5625 100644
--- a/doc/api/merge_request_approvals.md
+++ b/doc/api/merge_request_approvals.md
@@ -704,7 +704,7 @@ POST /projects/:id/merge_requests/:merge_request_iid/approval_rules
| `users` | integer | no | The ids of users as approvers |
| `groups` | integer | no | The ids of groups as approvers |
-**Important:** WHen `approval_project_rule_id` is set, the `name`, `users` and
+**Important:** When `approval_project_rule_id` is set, the `name`, `users` and
`groups` of project-level rule will be copied. The `approvals_required` specified
will be used.
@@ -777,6 +777,9 @@ PUT /projects/:id/merge_request/:merge_request_iid/approval_rules/:approval_rule
**Important:** Approvers and groups not in the `users`/`groups` param will be **removed**
+**Important:** Updating a `report_approver` or `code_owner` rule is not allowed.
+These are system generated rules.
+
**Parameters:**
| Attribute | Type | Required | Description |
@@ -856,6 +859,9 @@ You can delete merge request approval rules using the following endpoint:
DELETE /projects/:id/merge_requests/:merge_request_iid/approval_rules/:approval_rule_id
```
+**Important:** Deleting a `report_approver` or `code_owner` rule is not allowed.
+These are system generated rules.
+
**Parameters:**
| Attribute | Type | Required | Description |