diff options
| author | Shinya Maeda <shinya@gitlab.com> | 2017-12-04 22:18:58 +0900 |
|---|---|---|
| committer | Shinya Maeda <shinya@gitlab.com> | 2017-12-04 22:18:58 +0900 |
| commit | f17375b9d03ed420c83ed41d58e363a022606c68 (patch) | |
| tree | 8b58e5f555c5be7ba248e73cf822a7b4c189c1f6 | |
| parent | 6b1ad363dc3902fa5052aee8a2f98b128fd617e6 (diff) | |
| download | gitlab-ce-f17375b9d03ed420c83ed41d58e363a022606c68.tar.gz | |
Optimize Clusters::CreateService#execute
| -rw-r--r-- | app/controllers/projects/clusters/user_controller.rb | 2 | ||||
| -rw-r--r-- | app/services/clusters/create_service.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/projects/clusters/user_controller.rb b/app/controllers/projects/clusters/user_controller.rb index 7f108c54b19..d7678512073 100644 --- a/app/controllers/projects/clusters/user_controller.rb +++ b/app/controllers/projects/clusters/user_controller.rb @@ -11,7 +11,7 @@ class Projects::Clusters::UserController < Projects::ApplicationController def create @cluster = ::Clusters::CreateService .new(project, current_user, create_params) - .execute(nil) + .execute if @cluster.persisted? redirect_to project_cluster_path(project, @cluster) diff --git a/app/services/clusters/create_service.rb b/app/services/clusters/create_service.rb index 1d407739b21..7b697f6d807 100644 --- a/app/services/clusters/create_service.rb +++ b/app/services/clusters/create_service.rb @@ -2,7 +2,7 @@ module Clusters class CreateService < BaseService attr_reader :access_token - def execute(access_token) + def execute(access_token = nil) @access_token = access_token create_cluster.tap do |cluster| |