diff options
| author | Dirk Hörner <dirker@gmail.com> | 2016-08-29 14:33:19 +0000 |
|---|---|---|
| committer | Dirk Hörner <dirker@gmail.com> | 2016-08-30 13:35:50 +0200 |
| commit | 2e442840548c5de132723d611dbeefe2ef6105d3 (patch) | |
| tree | c17d10af513a864ffbc0f610dab89b19a18c0252 | |
| parent | 84748c86ec83f9b2fab66197a0b808f8c0c2c49f (diff) | |
| download | gitlab-ce-2e442840548c5de132723d611dbeefe2ef6105d3.tar.gz | |
lib/backup: fix broken permissions when creating repo dir
This commit fixes a typo where the mode argument to FileUtils.mkdir()
would be passed in decimal rather than octal format, yielding bad
permissions.
| -rw-r--r-- | CHANGELOG | 3 | ||||
| -rw-r--r-- | lib/backup/repository.rb | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/CHANGELOG b/CHANGELOG index 83a5d1727f3..2a91c099fb1 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -37,6 +37,9 @@ v 8.12.0 (unreleased) - Use the default branch for displaying the project icon instead of master !5792 (Hannes Rosenögger) - Adds response mime type to transaction metric action when it's not HTML +v 8.11.4 (unreleased) + - Fix broken gitlab:backup:restore because of bad permissions on repo storage !6098 (Dirk Hörner) + v 8.11.3 (unreleased) - Allow system info page to handle case where info is unavailable - Label list shows all issues (opened or closed) with that label diff --git a/lib/backup/repository.rb b/lib/backup/repository.rb index f117fc3d37d..9fcd9a3f999 100644 --- a/lib/backup/repository.rb +++ b/lib/backup/repository.rb @@ -55,7 +55,7 @@ module Backup bk_repos_path = File.join(path, '..', 'repositories.old.' + Time.now.to_i.to_s) FileUtils.mv(path, bk_repos_path) # This is expected from gitlab:check - FileUtils.mkdir_p(path, mode: 2770) + FileUtils.mkdir_p(path, mode: 02770) end Project.find_each(batch_size: 1000) do |project| |