summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmit Rathi <amit.juschill@gmail.com>2019-08-01 14:36:16 +0000
committerMike Greiling <mike@pixelcog.com>2019-08-01 14:36:16 +0000
commitf485686131b9fb2655856ddc35b011cb30dc90da (patch)
treead150b0ee4476764e39ec3e6dcd78e00ec192b78
parent760e75c8fa809fa6d3233700aa7eb99c15458d5a (diff)
downloadgitlab-ce-f485686131b9fb2655856ddc35b011cb30dc90da.tar.gz
Jupyter fix hostname editing and remove extra load balancer
-rw-r--r--app/assets/javascripts/clusters/stores/clusters_store.js1
-rw-r--r--changelogs/unreleased/jupyter-fixes-v1.yml5
-rw-r--r--vendor/jupyter/values.yaml4
3 files changed, 10 insertions, 0 deletions
diff --git a/app/assets/javascripts/clusters/stores/clusters_store.js b/app/assets/javascripts/clusters/stores/clusters_store.js
index f64f0ca616f..ada5a49e246 100644
--- a/app/assets/javascripts/clusters/stores/clusters_store.js
+++ b/app/assets/javascripts/clusters/stores/clusters_store.js
@@ -171,6 +171,7 @@ export default class ClusterStore {
this.state.applications.cert_manager.email || serverAppEntry.email;
} else if (appId === JUPYTER) {
this.state.applications.jupyter.hostname =
+ this.state.applications.jupyter.hostname ||
serverAppEntry.hostname ||
(this.state.applications.ingress.externalIp
? `jupyter.${this.state.applications.ingress.externalIp}.nip.io`
diff --git a/changelogs/unreleased/jupyter-fixes-v1.yml b/changelogs/unreleased/jupyter-fixes-v1.yml
new file mode 100644
index 00000000000..7a34f273c90
--- /dev/null
+++ b/changelogs/unreleased/jupyter-fixes-v1.yml
@@ -0,0 +1,5 @@
+---
+title: Jupyter fixes
+merge_request: 31332
+author: Amit Rathi
+type: fixed
diff --git a/vendor/jupyter/values.yaml b/vendor/jupyter/values.yaml
index 2aadd3dbe1e..852c6c3f2b0 100644
--- a/vendor/jupyter/values.yaml
+++ b/vendor/jupyter/values.yaml
@@ -57,3 +57,7 @@ ingress:
annotations:
kubernetes.io/ingress.class: "nginx"
kubernetes.io/tls-acme: "true"
+
+proxy:
+ service:
+ type: ClusterIP