diff options
author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-04-03 10:02:03 +0000 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-04-03 10:02:03 +0000 |
commit | fee8dcde1960470b6c9890993f0dfd08dfc63ed1 (patch) | |
tree | 5d8c30d2222fe3ba3e0032187af1302177032e95 | |
parent | e7e9307219d1c81427f95444b36471c519dc06c2 (diff) | |
parent | 2332bf34ac417bb8a0aaba9482379bcfadb6d26e (diff) | |
download | gitlab-ce-fee8dcde1960470b6c9890993f0dfd08dfc63ed1.tar.gz |
Merge branch 'todo-update-order' into 'master'
Remove unnecessary ORDER BY clause when updating todos
See merge request !10399
-rw-r--r-- | app/services/todo_service.rb | 2 | ||||
-rw-r--r-- | changelogs/unreleased/todo-update-order.yml | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/services/todo_service.rb b/app/services/todo_service.rb index 2c56cb4c680..b6e88b0280f 100644 --- a/app/services/todo_service.rb +++ b/app/services/todo_service.rb @@ -204,7 +204,7 @@ class TodoService # Only update those that are not really on that state todos = todos.where.not(state: state) todos_ids = todos.pluck(:id) - todos.update_all(state: state) + todos.unscope(:order).update_all(state: state) current_user.update_todos_count_cache todos_ids end diff --git a/changelogs/unreleased/todo-update-order.yml b/changelogs/unreleased/todo-update-order.yml new file mode 100644 index 00000000000..2046b6df11e --- /dev/null +++ b/changelogs/unreleased/todo-update-order.yml @@ -0,0 +1,4 @@ +--- +title: Remove unnecessary ORDER BY clause when updating todos +merge_request: +author: mhasbini |