diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-07-26 11:54:10 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-07-26 11:54:10 +0000 |
| commit | 63fe21c8bf4f8df872ded0ce3f86eb4c016a915e (patch) | |
| tree | 53b1ce06e50d21696d12f1ccbe499f7c4dff9751 | |
| parent | 2f5fdfe3f2848542b9930f4144723706451cfbc0 (diff) | |
| parent | 3abffb2be25844920d6e0b2ac9735ebb38b78ef5 (diff) | |
| download | gitlab-ce-63fe21c8bf4f8df872ded0ce3f86eb4c016a915e.tar.gz | |
Merge branch '20241-expand-all-button-breaks-diff-comparison-view' into 'master'
Fix expand all diffs button in compare view
## What does this MR do?
Fix the expand all diffs button in compare view.
## Are there points in the code the reviewer needs to double check?
Don't think so.
## Why was this MR needed?
We can't reuse the existing value of the format parameter, because on
the merge request page that's 'json', so the link would go to a JSON
file. We can't set it to HTML, because that adds '.html' to the URL, which
breaks the compare view (and looks bad). Setting it to `nil` uses the
default format, which in all of these cases is HTML anyway.
## What are the relevant issue numbers?
Closes #20241.
See merge request !5500
| -rw-r--r-- | CHANGELOG | 1 | ||||
| -rw-r--r-- | app/views/projects/diffs/_diffs.html.haml | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG b/CHANGELOG index 68c8b165f67..3d18f50f9d2 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -23,6 +23,7 @@ v 8.10.2 (unreleased) - Use project ID in repository cache to prevent stale data from persisting across projects. !5460 - Ensure relative paths for video are rewritten as we do for images. !5474 - Ensure current user can retry a build before showing the 'Retry' button. !5476 + - Fix expand all diffs button in compare view v 8.10.1 - Refactor repository storages documentation. !5428 diff --git a/app/views/projects/diffs/_diffs.html.haml b/app/views/projects/diffs/_diffs.html.haml index 8ae433b4823..4bf3ccace20 100644 --- a/app/views/projects/diffs/_diffs.html.haml +++ b/app/views/projects/diffs/_diffs.html.haml @@ -7,7 +7,7 @@ .content-block.oneline-block.files-changed .inline-parallel-buttons - if !expand_all_diffs? && diff_files.any? { |diff_file| diff_file.collapsed? } - = link_to 'Expand all', url_for(params.merge(expand_all_diffs: 1, format: 'html')), class: 'btn btn-default' + = link_to 'Expand all', url_for(params.merge(expand_all_diffs: 1, format: nil)), class: 'btn btn-default' - if show_whitespace_toggle - if current_controller?(:commit) = commit_diff_whitespace_link(@project, @commit, class: 'hidden-xs') |