diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-10-26 12:12:10 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-10-26 12:12:10 +0000 |
commit | b0e6fc12653cfc726e8d5710e850e8609a44dcf3 (patch) | |
tree | 348ea4cbd838d137d4c376502dec4881853e1124 | |
parent | c2325d3fa6ca2842d8059f377322abca18825ef4 (diff) | |
parent | eed4b2c5c4ce765104b05cb664e8c6b68b39f219 (diff) | |
download | gitlab-ce-b0e6fc12653cfc726e8d5710e850e8609a44dcf3.tar.gz |
Merge branch '21248-wrong-urlencoding-when-switching-branch-in-graphs-contributers' into 'master'
Fix refs dropdown selection with special characters
## What does this MR do?
Remove unneeded encode from the project-refs-dropdown renderRow method.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
![2016-10-23_01.20.19](/uploads/1f176b2aa633093851799ae9f70f116b/2016-10-23_01.20.19.gif)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21248
See merge request !7061
-rw-r--r-- | app/assets/javascripts/project.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/assets/javascripts/project.js b/app/assets/javascripts/project.js index b370e6bb9f8..61c33dc1f20 100644 --- a/app/assets/javascripts/project.js +++ b/app/assets/javascripts/project.js @@ -78,7 +78,7 @@ if (ref.header != null) { return $('<li />').addClass('dropdown-header').text(ref.header); } else { - link = $('<a />').attr('href', '#').addClass(ref === selected ? 'is-active' : '').text(ref).attr('data-ref', escape(ref)); + link = $('<a />').attr('href', '#').addClass(ref === selected ? 'is-active' : '').text(ref).attr('data-ref', ref); return $('<li />').append(link); } }, |