diff options
author | Rémy Coutable <remy@rymai.me> | 2016-04-13 14:28:19 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-04-13 14:28:19 +0000 |
commit | e359f870f2ea95a76c36c10bbeee540b3cbfdb6b (patch) | |
tree | 4dceb28c31d30d939dcffbf141afdd400e340ec2 | |
parent | dabedd1d8c766b968b21a9353dc1a9225f7b2468 (diff) | |
parent | 3b9edce803c91b5f51675291fdf22f1159cea456 (diff) | |
download | gitlab-ce-e359f870f2ea95a76c36c10bbeee540b3cbfdb6b.tar.gz |
Merge branch 'instrument-house-keeping' into 'master'
Instrument the HousekeepingService class
I'm starting with instrumenting this class as mentioned in https://gitlab.com/gitlab-org/gitlab-ce/issues/15094#note_4796278.
See merge request !3701
-rw-r--r-- | CHANGELOG | 1 | ||||
-rw-r--r-- | app/services/projects/housekeeping_service.rb | 14 |
2 files changed, 11 insertions, 4 deletions
diff --git a/CHANGELOG b/CHANGELOG index 5399e3e5b8b..ec8db471572 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ Please view this file on the master branch, on stable branches it's out of date. v 8.7.0 (unreleased) + - The Projects::HousekeepingService class has extra instrumentation (Yorick Peterse) - All service classes (those residing in app/services) are now instrumented (Yorick Peterse) - Developers can now add custom tags to transactions (Yorick Peterse) - Enable gzip for assets, makes the page size significantly smaller. !3544 / !3632 (Connor Shea) diff --git a/app/services/projects/housekeeping_service.rb b/app/services/projects/housekeeping_service.rb index a0973c5d260..3b7c36f0908 100644 --- a/app/services/projects/housekeeping_service.rb +++ b/app/services/projects/housekeeping_service.rb @@ -26,7 +26,9 @@ module Projects GitlabShellOneShotWorker.perform_async(:gc, @project.path_with_namespace) ensure - @project.update_column(:pushes_since_gc, 0) + Gitlab::Metrics.measure(:reset_pushes_since_gc) do + @project.update_column(:pushes_since_gc, 0) + end end def needed? @@ -34,14 +36,18 @@ module Projects end def increment! - @project.increment!(:pushes_since_gc) + Gitlab::Metrics.measure(:increment_pushes_since_gc) do + @project.increment!(:pushes_since_gc) + end end private def try_obtain_lease - lease = ::Gitlab::ExclusiveLease.new("project_housekeeping:#{@project.id}", timeout: LEASE_TIMEOUT) - lease.try_obtain + Gitlab::Metrics.measure(:obtain_housekeeping_lease) do + lease = ::Gitlab::ExclusiveLease.new("project_housekeeping:#{@project.id}", timeout: LEASE_TIMEOUT) + lease.try_obtain + end end end end |