summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2016-07-25 16:06:30 +0100
committerPhil Hughes <me@iamphill.com>2016-08-17 17:12:47 +0100
commite029c224d71e18ef266ad5ffe883740a226bbf4e (patch)
treecc49a187256b8387df6cf9dea74288d1090a6016
parent91500adfbe4ca26c82f9fdb0402f1fd4af726d0c (diff)
downloadgitlab-ce-e029c224d71e18ef266ad5ffe883740a226bbf4e.tar.gz
Fades out the other boards when marking as done
-rw-r--r--app/assets/javascripts/boards/components/board.js.coffee1
-rw-r--r--app/assets/javascripts/boards/components/board_list.js.coffee8
-rw-r--r--app/assets/stylesheets/pages/boards.scss4
-rw-r--r--app/views/projects/boards/components/_board.html.haml8
-rw-r--r--app/views/projects/boards/components/_card.html.haml2
5 files changed, 16 insertions, 7 deletions
diff --git a/app/assets/javascripts/boards/components/board.js.coffee b/app/assets/javascripts/boards/components/board.js.coffee
index fde62ba569b..0ed5a5b7bbc 100644
--- a/app/assets/javascripts/boards/components/board.js.coffee
+++ b/app/assets/javascripts/boards/components/board.js.coffee
@@ -7,6 +7,7 @@ Board = Vue.extend
clearSearch: ->
this.query = ''
computed:
+ newDone: -> BoardsStore.state.done
isPreset: ->
typeof this.board.id != 'number'
ready: ->
diff --git a/app/assets/javascripts/boards/components/board_list.js.coffee b/app/assets/javascripts/boards/components/board_list.js.coffee
index 7dcb203d265..88c3685efaf 100644
--- a/app/assets/javascripts/boards/components/board_list.js.coffee
+++ b/app/assets/javascripts/boards/components/board_list.js.coffee
@@ -5,11 +5,10 @@ BoardList = Vue.extend
filters: Object
issues: Array
query: String
+ done: Object
data: ->
scrollOffset: 20
loadMore: false
- computed:
- newDone: -> BoardsStore.state.done
methods:
listHeight: -> this.$els.list.getBoundingClientRect().height
scrollHeight: -> this.$els.list.scrollHeight
@@ -19,6 +18,11 @@ BoardList = Vue.extend
setTimeout =>
this.loadMore = false
, 2000
+ doneFilter: (issue) ->
+ if this.boardId is 'done' and this.done?.issue?
+ issue.id is this.done.issue.id
+ else
+ issue
customFilter: (issue) ->
returnIssue = issue
if this.filters.author?.id
diff --git a/app/assets/stylesheets/pages/boards.scss b/app/assets/stylesheets/pages/boards.scss
index 3bf3fc2fe88..76eef6a884a 100644
--- a/app/assets/stylesheets/pages/boards.scss
+++ b/app/assets/stylesheets/pages/boards.scss
@@ -37,6 +37,10 @@
height: 100%;
padding-right: ($gl-padding / 2);
padding-left: ($gl-padding / 2);
+
+ &.is-faded {
+ opacity: .4;
+ }
}
.board-inner {
diff --git a/app/views/projects/boards/components/_board.html.haml b/app/views/projects/boards/components/_board.html.haml
index 992eb0b9746..3af36640839 100644
--- a/app/views/projects/boards/components/_board.html.haml
+++ b/app/views/projects/boards/components/_board.html.haml
@@ -1,5 +1,5 @@
%board{ "inline-template" => true, "v-cloak" => true, "v-for" => "board in state.boards | orderBy 'index'", ":board" => "board" }
- .board{ ":class" => "{ 'is-draggable': !isPreset }" }
+ .board{ ":class" => "{ 'is-draggable': !isPreset, 'is-faded': board.id != 'done' && newDone.issue }" }
.board-inner
%header.board-inner-container.board-header{ ":class" => "{ 'has-border': board.label }", ":style" => "{ borderTopColor: board.label.backgroundColor }" }
%h3.board-title
@@ -18,10 +18,10 @@
%span.sr-only
Clear search
= icon("times", class: "board-search-clear")
- %board-list{ "inline-template" => true, ":board-id" => "board.id", ":issues" => "board.issues", ":disabled" => "#{current_user.nil?}", ":query" => "query", ":filters" => "filters" }
- %ul.board-list{ "v-el:list" => true, ":data-board" => "boardId", ":class" => "{ 'is-marking-done': boardId == 'done' && newDone.board }" }
+ %board-list{ "inline-template" => true, ":board-id" => "board.id", ":issues" => "board.issues", ":disabled" => "#{current_user.nil?}", ":query" => "query", ":filters" => "filters", ":done" => "newDone" }
+ %ul.board-list{ "v-el:list" => true, ":data-board" => "boardId", ":class" => "{ 'is-marking-done': boardId == 'done' && done.board }" }
= render "projects/boards/components/card"
- %issue-done{ "inline-template" => true, ":done" => "newDone", "v-if" => "boardId == 'done' && newDone.board" }
+ %issue-done{ "inline-template" => true, ":done" => "done", "v-if" => "boardId == 'done' && done.board" }
.board-done
%p
This issue is currently in the following lists:
diff --git a/app/views/projects/boards/components/_card.html.haml b/app/views/projects/boards/components/_card.html.haml
index db11654d72f..e5ea8cf608a 100644
--- a/app/views/projects/boards/components/_card.html.haml
+++ b/app/views/projects/boards/components/_card.html.haml
@@ -1,4 +1,4 @@
-%li.card{ ":data-issue" => "issue.id", "v-for" => "issue in issues | filterBy query in 'title' | filterBy customFilter" }
+%li.card{ ":data-issue" => "issue.id", "v-for" => "issue in issues | filterBy query in 'title' | filterBy customFilter | filterBy doneFilter" }
%h4.card-title
%a{ href: "#", ":title" => "issue.title" }
{{ issue.title }}