summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2016-07-20 00:39:41 +0800
committerLin Jen-Shin <godfat@godfat.org>2016-07-20 00:39:41 +0800
commitae83ac9969973fe58bc0ec3b65bd6071fad8623f (patch)
tree8e52d610e228f09b076542f58f9891b6f6db1fa7
parent6da27aa6a583ddb4d73b9dfaaaa3e9fdf98e9a6d (diff)
downloadgitlab-ce-ae83ac9969973fe58bc0ec3b65bd6071fad8623f.tar.gz
path_from_ref -> path_for_ref, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173404
-rw-r--r--spec/requests/api/builds_spec.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/requests/api/builds_spec.rb b/spec/requests/api/builds_spec.rb
index ef489a1ee90..f28c027287f 100644
--- a/spec/requests/api/builds_spec.rb
+++ b/spec/requests/api/builds_spec.rb
@@ -201,7 +201,7 @@ describe API::API, api: true do
project.team << [user, :developer]
end
- def path_from_ref(ref = pipeline.ref, job = build.name)
+ def path_for_ref(ref = pipeline.ref, job = build.name)
api("/projects/#{project.id}/builds/artifacts/#{ref}/download?job=#{job}", user)
end
@@ -209,7 +209,7 @@ describe API::API, api: true do
let(:user) { nil }
before do
- get path_from_ref
+ get path_for_ref
end
it { expect(response).to have_http_status(401) }
@@ -222,7 +222,7 @@ describe API::API, api: true do
context 'has no such ref' do
before do
- get path_from_ref('TAIL', build.name)
+ get path_for_ref('TAIL', build.name)
end
it('gives 404') { verify }
@@ -230,7 +230,7 @@ describe API::API, api: true do
context 'has no such build' do
before do
- get path_from_ref(pipeline.ref, 'NOBUILD')
+ get path_for_ref(pipeline.ref, 'NOBUILD')
end
it('gives 404') { verify }
@@ -260,7 +260,7 @@ describe API::API, api: true do
end
before do
- get path_from_ref('master')
+ get path_for_ref('master')
end
it('gives the file') { verify }
@@ -273,7 +273,7 @@ describe API::API, api: true do
end
before do
- get path_from_ref('improve/awesome')
+ get path_for_ref('improve/awesome')
end
it('gives the file') { verify }
@@ -287,7 +287,7 @@ describe API::API, api: true do
end
before do
- get path_from_ref
+ get path_for_ref
end
it('gives the file') { verify }
@@ -300,7 +300,7 @@ describe API::API, api: true do
end
before do
- get path_from_ref
+ get path_for_ref
end
it('gives the file') { verify }