diff options
| author | Douwe Maan <douwe@selenight.nl> | 2017-02-21 17:41:04 -0600 |
|---|---|---|
| committer | Douwe Maan <douwe@selenight.nl> | 2017-02-23 09:31:57 -0600 |
| commit | 378ad332dd9fc84bb85af2300ae4e6ce828818ab (patch) | |
| tree | 37e3415b7621f6ba08bf7b548d0d1dec77ded0e8 | |
| parent | 73382c2feac59a2fe8ec773b16b8cfb3a884fe38 (diff) | |
| download | gitlab-ce-378ad332dd9fc84bb85af2300ae4e6ce828818ab.tar.gz | |
Disable a few RSpec cops
| -rw-r--r-- | .rubocop.yml | 27 | ||||
| -rw-r--r-- | .rubocop_todo.yml | 63 |
2 files changed, 27 insertions, 63 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index 6622e213617..6151d6c570c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -861,3 +861,30 @@ RSpec/NotToNot: # Prefer using verifying doubles over normal doubles. RSpec/VerifiedDoubles: Enabled: false + +RSpec/MultipleExpectations: + Enabled: false + +RSpec/NamedSubject: + Enabled: false + +RSpec/NestedGroups: + Enabled: false + +RSpec/LeadingSubject: + Enabled: false + +RSpec/LetSetup: + Enabled: false + +RSpec/MessageChain: + Enabled: false + +RSpec/MessageSpies: + Enabled: false + +RSpec/RepeatedDescription: + Enabled: false + +RSpec/SubjectStub: + Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 31569250877..085e593c6b9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -124,74 +124,11 @@ RSpec/ImplicitExpect: - 'spec/models/project_services/external_wiki_service_spec.rb' - 'spec/models/project_spec.rb' -# Offense count: 258 -RSpec/LeadingSubject: - Enabled: false - -# Offense count: 281 -RSpec/LetSetup: - Enabled: false - -# Offense count: 13 -RSpec/MessageChain: - Exclude: - - 'spec/finders/move_to_project_finder_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - - 'spec/initializers/secret_token_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/requests/api/internal_spec.rb' - - 'spec/services/ci/retry_build_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/workers/emails_on_push_worker_spec.rb' - -# Offense count: 505 -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: have_received, receive -RSpec/MessageSpies: - Enabled: false - -# Offense count: 3625 -RSpec/MultipleExpectations: - Max: 37 - -# Offense count: 2217 -RSpec/NamedSubject: - Enabled: false - -# Offense count: 2126 -# Configuration parameters: MaxNesting. -RSpec/NestedGroups: - Enabled: false - -# Offense count: 36 -RSpec/RepeatedDescription: - Exclude: - - 'spec/controllers/projects/todo_controller_spec.rb' - - 'spec/features/boards/boards_spec.rb' - - 'spec/helpers/issuables_helper_spec.rb' - - 'spec/lib/banzai/filter/emoji_filter_spec.rb' - - 'spec/models/commit_range_spec.rb' - - 'spec/models/global_milestone_spec.rb' - - 'spec/models/hooks/system_hook_spec.rb' - - 'spec/requests/api/commits_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/milestones_spec.rb' - - 'spec/requests/api/users_spec.rb' - - 'spec/requests/api/v3/merge_requests_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/routing/admin_routing_spec.rb' - - 'spec/services/notification_service_spec.rb' - # Offense count: 1 RSpec/SingleArgumentMessageChain: Exclude: - 'spec/requests/api/internal_spec.rb' -# Offense count: 140 -RSpec/SubjectStub: - Enabled: false - # Offense count: 126 # Cop supports --auto-correct. # Configuration parameters: Whitelist. |