diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-11-02 17:42:19 +0000 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-11-02 17:42:19 +0000 |
| commit | 1d4efeec2e1a203be113077e6504d8f256271db1 (patch) | |
| tree | 9fab5a4afc278046885bd5ae82408ab96c7a4904 | |
| parent | 52115b905a72030afd536922389ed42991aec4cb (diff) | |
| parent | 8a0e314463f16618f4e227f0decf0661d6bdd4b5 (diff) | |
| download | gitlab-ce-1d4efeec2e1a203be113077e6504d8f256271db1.tar.gz | |
Merge branch 'pawel/disable_nfs_metrics_checks_39730' into 'master'
Remove Filesystem check metrics that use too much CPU to handle requests
See merge request gitlab-org/gitlab-ce!15158
| -rw-r--r-- | app/services/metrics_service.rb | 3 | ||||
| -rw-r--r-- | changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml | 5 | ||||
| -rw-r--r-- | spec/controllers/metrics_controller_spec.rb | 11 |
3 files changed, 6 insertions, 13 deletions
diff --git a/app/services/metrics_service.rb b/app/services/metrics_service.rb index a02eee4961b..6b3939aeba5 100644 --- a/app/services/metrics_service.rb +++ b/app/services/metrics_service.rb @@ -6,8 +6,7 @@ class MetricsService Gitlab::HealthChecks::Redis::RedisCheck, Gitlab::HealthChecks::Redis::CacheCheck, Gitlab::HealthChecks::Redis::QueuesCheck, - Gitlab::HealthChecks::Redis::SharedStateCheck, - Gitlab::HealthChecks::FsShardsCheck + Gitlab::HealthChecks::Redis::SharedStateCheck ].freeze def prometheus_metrics_text diff --git a/changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml b/changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml new file mode 100644 index 00000000000..556d7d069d3 --- /dev/null +++ b/changelogs/unreleased/pawel-disable_nfs_metrics_checks_39730.yml @@ -0,0 +1,5 @@ +--- +title: Remove Filesystem check metrics that use too much CPU to handle requests +merge_request: +author: +type: performance diff --git a/spec/controllers/metrics_controller_spec.rb b/spec/controllers/metrics_controller_spec.rb index 7b0976e3e67..4aed2a25baa 100644 --- a/spec/controllers/metrics_controller_spec.rb +++ b/spec/controllers/metrics_controller_spec.rb @@ -59,17 +59,6 @@ describe MetricsController do expect(response.body).to match(/^redis_shared_state_ping_latency_seconds [0-9\.]+$/) end - it 'returns file system check metrics' do - get :index - - expect(response.body).to match(/^filesystem_access_latency_seconds{shard="default"} [0-9\.]+$/) - expect(response.body).to match(/^filesystem_accessible{shard="default"} 1$/) - expect(response.body).to match(/^filesystem_write_latency_seconds{shard="default"} [0-9\.]+$/) - expect(response.body).to match(/^filesystem_writable{shard="default"} 1$/) - expect(response.body).to match(/^filesystem_read_latency_seconds{shard="default"} [0-9\.]+$/) - expect(response.body).to match(/^filesystem_readable{shard="default"} 1$/) - end - context 'prometheus metrics are disabled' do before do allow(Gitlab::Metrics).to receive(:prometheus_metrics_enabled?).and_return(false) |