diff options
| author | Phil Hughes <me@iamphill.com> | 2017-05-11 07:39:26 +0000 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2017-05-11 07:39:26 +0000 |
| commit | 64d6569c12fac484ea240cdc9d3be255d83fe523 (patch) | |
| tree | 0268cac3b336f3fe0b02b207512b4704a6156079 | |
| parent | 1ccf101eef7db401317838a453795fa1c28ec036 (diff) | |
| parent | f4b6865aef48b6c328fd297b499b53f5d37260d9 (diff) | |
| download | gitlab-ce-64d6569c12fac484ea240cdc9d3be255d83fe523.tar.gz | |
Merge branch '32094-custom-notifications-model-aria-labelledby-incorrect' into 'master'
Fix aria labels on custom notifications modal
Closes #32094
See merge request !11256
| -rw-r--r-- | app/views/shared/notifications/_custom_notifications.html.haml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/views/shared/notifications/_custom_notifications.html.haml b/app/views/shared/notifications/_custom_notifications.html.haml index 708adbc38f1..183ed34fba1 100644 --- a/app/views/shared/notifications/_custom_notifications.html.haml +++ b/app/views/shared/notifications/_custom_notifications.html.haml @@ -1,9 +1,9 @@ -.modal.fade{ tabindex: "-1", role: "dialog", id: notifications_menu_identifier("modal", notification_setting), aria: { labelledby: "custom-notifications-title" } } +.modal.fade{ tabindex: "-1", role: "dialog", id: notifications_menu_identifier("modal", notification_setting), "aria-labelledby": "custom-notifications-title" } .modal-dialog .modal-content .modal-header - %button.close{ type: "button", data: { dismiss: "modal" }, aria: { label: "close" } } - %span{ aria: { hidden: "true" } } × + %button.close{ type: "button", "aria-label": "close", data: { dismiss: "modal" } } + %span{ "aria-hidden": "true" } } × %h4#custom-notifications-title.modal-title Custom notification events |