Don't check inclusion inside helper

1 files changed, 6 insertions, 7 deletions

diff --git a/lib/gitlab/markup_helper.rb b/lib/gitlab/markup_helper.rb
index a7b73432efc..22bd58290f8 100644
--- a/lib/gitlab/markup_helper.rb
+++ b/lib/gitlab/markup_helper.rb
@@ -13,7 +13,7 @@ module Gitlab
     #
     # Returns boolean
     def markup?(filename)
-      extension?(filename, EXTENSIONS)
+      EXTENSIONS.include?(extension(filename))
     end
 
     # Public: Determines if a given filename is compatible with
@@ -23,7 +23,7 @@ module Gitlab
     #
     # Returns boolean
     def gitlab_markdown?(filename)
-      extension?(filename, MARKDOWN_EXTENSIONS)
+      MARKDOWN_EXTENSIONS.include?(extension(filename))
     end
 
     # Public: Determines if the given filename has AsciiDoc extension.
@@ -32,7 +32,7 @@ module Gitlab
     #
     # Returns boolean
     def asciidoc?(filename)
-      extension?(filename, ASCIIDOC_EXTENSIONS)
+      ASCIIDOC_EXTENSIONS.include?(extension(filename))
     end
 
     # Public: Determines if the given filename is plain text.
@@ -41,8 +41,7 @@ module Gitlab
     #
     # Returns boolean
     def plain?(filename)
-      extension?(filename, %w(txt)) ||
-        filename.downcase == 'readme'
+      extension(filename) == 'txt' || filename.downcase == 'readme'
     end
 
     def previewable?(filename)
@@ -51,8 +50,8 @@ module Gitlab
 
     private
 
-    def extension?(filename, extensions)
-      extensions.include?(File.extname(filename).downcase.delete('.'))
+    def extension(filename)
+      File.extname(filename).downcase.delete('.')
     end
   end
 end