diff options
author | Alfredo Sumaran <alfredo@gitlab.com> | 2017-03-16 19:43:10 +0000 |
---|---|---|
committer | Alfredo Sumaran <alfredo@gitlab.com> | 2017-03-16 19:43:10 +0000 |
commit | c2d3ea04f6a4b6393cc1cb3c44ffa21f0cee1e51 (patch) | |
tree | 34276e67b937dd45f565dc548322e0a4583c808e | |
parent | adb7ed3f9a0f9fc513685988208957a25a9e1ae3 (diff) | |
parent | de14439ea4b7cc7e313af985ac6eaa95e4d0e8c3 (diff) | |
download | gitlab-ce-c2d3ea04f6a4b6393cc1cb3c44ffa21f0cee1e51.tar.gz |
Merge branch 'compare-remote-search' into 'master'
Enabled remote filter in compare dropdowns
Closes #29545
See merge request !9997
-rw-r--r-- | app/assets/javascripts/compare_autocomplete.js | 5 | ||||
-rw-r--r-- | spec/features/projects/compare_spec.rb | 8 |
2 files changed, 11 insertions, 2 deletions
diff --git a/app/assets/javascripts/compare_autocomplete.js b/app/assets/javascripts/compare_autocomplete.js index d91bfb1ccbd..72c0d98d47c 100644 --- a/app/assets/javascripts/compare_autocomplete.js +++ b/app/assets/javascripts/compare_autocomplete.js @@ -18,7 +18,8 @@ window.CompareAutocomplete = (function() { return $.ajax({ url: $dropdown.data('refs-url'), data: { - ref: $dropdown.data('ref') + ref: $dropdown.data('ref'), + search: term, } }).done(function(refs) { return callback(refs); @@ -26,7 +27,7 @@ window.CompareAutocomplete = (function() { }, selectable: true, filterable: true, - filterByText: true, + filterRemote: true, fieldName: $dropdown.data('field-name'), filterInput: 'input[type="search"]', renderRow: function(ref) { diff --git a/spec/features/projects/compare_spec.rb b/spec/features/projects/compare_spec.rb index 43eb4000e58..030043d14aa 100644 --- a/spec/features/projects/compare_spec.rb +++ b/spec/features/projects/compare_spec.rb @@ -26,6 +26,14 @@ describe "Compare", js: true do click_button "Compare" expect(page).to have_content "Commits" end + + it "filters branches" do + select_using_dropdown("from", "wip") + + find(".js-compare-from-dropdown .compare-dropdown-toggle").click + + expect(find(".js-compare-from-dropdown .dropdown-content")).to have_selector("li", count: 3) + end end describe "tags" do |