summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2016-06-15 09:14:01 +0000
committerYorick Peterse <yorickpeterse@gmail.com>2016-06-15 09:14:01 +0000
commit3589e549ab7b96488657b81f1739aa86f71933d4 (patch)
tree9477c97d3dfe8c6217125fee5296065dad64722e
parentd8563bd6c2408efb6890c536ed0852b99fa49423 (diff)
parent52a2b8a41001b35338bcc6d92fa4c9679c4196a8 (diff)
downloadgitlab-ce-3589e549ab7b96488657b81f1739aa86f71933d4.tar.gz
Merge branch '14320-note-grouped_awards' into 'master'
Include user relationship when retrieving award_emoji See merge request !4647
-rw-r--r--CHANGELOG1
-rw-r--r--app/models/concerns/awardable.rb8
2 files changed, 7 insertions, 2 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 6f5991a6607..59d326cab5a 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -91,6 +91,7 @@ v 8.9.0 (unreleased)
- Horizontally scrolling navigation on project, group, and profile settings pages
- Hide global side navigation by default
- Remove tanuki logo from side navigation; center on top nav
+ - Include user relationships when retrieving award_emoji
v 8.8.5 (unreleased)
- Ensure branch cleanup regardless of whether the GitHub import process succeeds
diff --git a/app/models/concerns/awardable.rb b/app/models/concerns/awardable.rb
index aa4b4201250..539c7c31e30 100644
--- a/app/models/concerns/awardable.rb
+++ b/app/models/concerns/awardable.rb
@@ -5,7 +5,7 @@ module Awardable
has_many :award_emoji, as: :awardable, dependent: :destroy
if self < Participable
- participant :award_emoji
+ participant :award_emoji_with_associations
end
end
@@ -34,8 +34,12 @@ module Awardable
end
end
+ def award_emoji_with_associations
+ award_emoji.includes(:user)
+ end
+
def grouped_awards(with_thumbs: true)
- awards = award_emoji.group_by(&:name)
+ awards = award_emoji_with_associations.group_by(&:name)
if with_thumbs
awards[AwardEmoji::UPVOTE_NAME] ||= []