diff options
| author | Philippe Lafoucrière <plafoucriere@gitlab.com> | 2018-11-27 20:59:58 +0000 |
|---|---|---|
| committer | Philippe Lafoucrière <plafoucriere@gitlab.com> | 2018-11-27 20:59:58 +0000 |
| commit | ebea1e7c84e98271a1ced3ffbd58c87b9a322f5a (patch) | |
| tree | 3fd168fd1ccae61160a4f4e3d62a4763d480b871 | |
| parent | e95a3bbced176658f05dbc3007257d12f122f868 (diff) | |
| download | gitlab-ce-ebea1e7c84e98271a1ced3ffbd58c87b9a322f5a.tar.gz | |
Add section title for Approval guidelines
| -rw-r--r-- | doc/development/code_review.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index eb778ee5168..aabb1f4b707 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -32,6 +32,8 @@ widget. Reviewers can add their approval by [approving additionally](https://doc Getting your merge request **merged** also requires a maintainer. If it requires more than one approval, the last maintainer to review and approve it will also merge it. +### Approval guidelines + As described in the section on the responsibility of the maintainer below, you are recommended to get your merge request approved and merged by maintainer(s) from other teams than your own. @@ -49,7 +51,7 @@ from other teams than your own. 1. If your merge request includes a new dependency or a filesystem change, it must be **approved by a [Distribution team member][team]**. See how to work with the [Distribution team](https://about.gitlab.com/handbook/engineering/dev-backend/distribution/) for more details. -### Security requirements +#### Security requirements 1. If your merge request is processing, storing, or transferring any kind of [RED data][red data], and/or ORANGE data, it must be **approved by a [Security Engineer][team]**. |