diff options
author | Nick Thomas <nick@gitlab.com> | 2018-09-04 12:11:01 +0000 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2018-09-04 12:11:01 +0000 |
commit | afb49b044bcb71702edd3f5ef0139599ddc54ef5 (patch) | |
tree | 6f1807ceef4f43a9ed43bdc087176c6c5982312f | |
parent | 99fb3482ceaf7352a728bd36dc19fd9ad2ebb341 (diff) | |
parent | 97cabfb65c0474742b84ec70c0d34d9f7601c59c (diff) | |
download | gitlab-ce-afb49b044bcb71702edd3f5ef0139599ddc54ef5.tar.gz |
Merge branch 'sh-send-put-headers-object-storage' into 'master'
Send required object storage PUT headers in /uploads/authorize API
See merge request gitlab-org/gitlab-ce!21319
-rw-r--r-- | changelogs/unreleased/sh-send-put-headers-object-storage.yml | 5 | ||||
-rw-r--r-- | lib/object_storage/direct_upload.rb | 4 | ||||
-rw-r--r-- | spec/lib/object_storage/direct_upload_spec.rb | 2 |
3 files changed, 10 insertions, 1 deletions
diff --git a/changelogs/unreleased/sh-send-put-headers-object-storage.yml b/changelogs/unreleased/sh-send-put-headers-object-storage.yml new file mode 100644 index 00000000000..cbd8b6deb5b --- /dev/null +++ b/changelogs/unreleased/sh-send-put-headers-object-storage.yml @@ -0,0 +1,5 @@ +--- +title: Send back required object storage PUT headers in /uploads/authorize API +merge_request: 21319 +author: +type: changed diff --git a/lib/object_storage/direct_upload.rb b/lib/object_storage/direct_upload.rb index 61a69e7ffe4..b372b4af090 100644 --- a/lib/object_storage/direct_upload.rb +++ b/lib/object_storage/direct_upload.rb @@ -41,7 +41,9 @@ module ObjectStorage GetURL: get_url, StoreURL: store_url, DeleteURL: delete_url, - MultipartUpload: multipart_upload_hash + MultipartUpload: multipart_upload_hash, + CustomPutHeaders: true, + PutHeaders: upload_options }.compact end diff --git a/spec/lib/object_storage/direct_upload_spec.rb b/spec/lib/object_storage/direct_upload_spec.rb index e0569218d78..632acd6eb46 100644 --- a/spec/lib/object_storage/direct_upload_spec.rb +++ b/spec/lib/object_storage/direct_upload_spec.rb @@ -61,6 +61,8 @@ describe ObjectStorage::DirectUpload do expect(subject[:GetURL]).to start_with(storage_url) expect(subject[:StoreURL]).to start_with(storage_url) expect(subject[:DeleteURL]).to start_with(storage_url) + expect(subject[:CustomPutHeaders]).to be_truthy + expect(subject[:PutHeaders]).to eq({ 'Content-Type' => 'application/octet-stream' }) end end |