diff options
| author | Marcia Ramos <marcia@gitlab.com> | 2019-02-21 16:43:53 +0000 |
|---|---|---|
| committer | Marcia Ramos <marcia@gitlab.com> | 2019-02-21 16:43:53 +0000 |
| commit | cbeab67a270d550b9d925089af53e9cf6ac3d48a (patch) | |
| tree | 29c3e9545e02bddb7ea2d90fac92ee0f9b7635e7 | |
| parent | 6349a18588b58c57a4095a1364987b8bf4766612 (diff) | |
| download | gitlab-ce-cbeab67a270d550b9d925089af53e9cf6ac3d48a.tar.gz | |
Apply suggestion to doc/development/code_review.md
| -rw-r--r-- | doc/development/code_review.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 8de02d273ec..f115045dbb7 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -205,7 +205,7 @@ first time. - Try to respond to every comment. - The merge request author resolves only the discussions they have fully addressed. If there's an open reply, an open discussion, a suggestion, - a question, or anything else, the discussion must be left to be resolved + a question, or anything else, the discussion should be left to be resolved by the reviewer. - Push commits based on earlier rounds of feedback as isolated commits to the branch. Do not squash until the branch is ready to merge. Reviewers should be |