summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-10-19 15:56:08 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-10-19 15:56:08 +0000
commit54bd4b4f9209a2329868cac84347ad74d10d31d4 (patch)
treeff3eaa8b1f6097aee7bd3f53c0607d5e299bf3ed
parentcad56768d5f60f2d77f9b0a21a6f51ac517cbca9 (diff)
parentd32abeece331760d0e8a78fae0862f19fe2531b3 (diff)
downloadgitlab-ce-54bd4b4f9209a2329868cac84347ad74d10d31d4.tar.gz
Merge branch 'jivl-fix-bar-char-transient-spec-failure' into 'master'
Fix transient failure from the bar_chart.vue component Closes gitlab-ee#8062 See merge request gitlab-org/gitlab-ce!22495
-rw-r--r--changelogs/unreleased/jivl-fix-bar-char-transient-spec-failure.yml5
-rw-r--r--spec/javascripts/vue_shared/components/bar_chart_spec.js6
2 files changed, 5 insertions, 6 deletions
diff --git a/changelogs/unreleased/jivl-fix-bar-char-transient-spec-failure.yml b/changelogs/unreleased/jivl-fix-bar-char-transient-spec-failure.yml
new file mode 100644
index 00000000000..344997add74
--- /dev/null
+++ b/changelogs/unreleased/jivl-fix-bar-char-transient-spec-failure.yml
@@ -0,0 +1,5 @@
+---
+title: Fix transient spec error in the bar_chart component
+merge_request: 22495
+author:
+type: fixed
diff --git a/spec/javascripts/vue_shared/components/bar_chart_spec.js b/spec/javascripts/vue_shared/components/bar_chart_spec.js
index 7e91cd6f63f..8f753876e44 100644
--- a/spec/javascripts/vue_shared/components/bar_chart_spec.js
+++ b/spec/javascripts/vue_shared/components/bar_chart_spec.js
@@ -71,12 +71,6 @@ describe('Bar chart component', () => {
expect(barChart.xAxisLocation).toEqual('translate(100, 250)');
});
- it('Contains a total of 4 ticks across the y axis', () => {
- const ticks = barChart.$el.querySelector('.y-axis').querySelectorAll('.tick').length;
-
- expect(ticks).toEqual(4);
- });
-
it('rotates the x axis labels a total of 90 degress (CCW)', () => {
const xAxisLabel = barChart.$el.querySelector('.x-axis').querySelectorAll('text')[0];