summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Doits <markus.doits@stellenticket.de>2018-09-17 12:53:00 +0200
committerMarkus Doits <markus.doits@stellenticket.de>2018-11-07 13:00:42 +0100
commit93705f9e72cd14c89d6cf2d3e364611f51c8c038 (patch)
tree003b531874280c7ae3cd6b5a179e6cd085e08526
parent39204d8c6184328b21e4057aaa78d698abd56e29 (diff)
downloadgitlab-ce-93705f9e72cd14c89d6cf2d3e364611f51c8c038.tar.gz
fix some spec wording and values
-rw-r--r--spec/models/ci/build_spec.rb10
1 files changed, 5 insertions, 5 deletions
diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb
index 4f113d2e653..2b4923926db 100644
--- a/spec/models/ci/build_spec.rb
+++ b/spec/models/ci/build_spec.rb
@@ -1475,7 +1475,7 @@ describe Ci::Build do
context 'when max retries value is defined as an integer' do
subject { create(:ci_build, options: { retry: 1 }) }
- it 'returns a number of configured max retries' do
+ it 'returns the number of configured max retries' do
expect(subject.retries_max).to eq 1
end
end
@@ -1483,7 +1483,7 @@ describe Ci::Build do
context 'when retries value is defined as a hash' do
subject { create(:ci_build, options: { retry: { max: 1 } }) }
- it 'returns a number of configured max retries' do
+ it 'returns the number of configured max retries' do
expect(subject.retries_max).to eq 1
end
end
@@ -1491,7 +1491,7 @@ describe Ci::Build do
context 'when retries value is defined as a hash without max key' do
subject { create(:ci_build, options: { retry: { something: :else } }) }
- it 'returns a number of configured max retries' do
+ it 'returns zero' do
expect(subject.retries_max).to eq 0
end
end
@@ -1522,7 +1522,7 @@ describe Ci::Build do
end
end
- context 'when value is defined without as an array' do
+ context 'when value is defined as an array' do
subject { create(:ci_build, options: { retry: { when: %w[something more] } }) }
it 'returns the configured value' do
@@ -1579,7 +1579,7 @@ describe Ci::Build do
context 'and retry when is always' do
before do
- expect(subject).to receive(:retry_when).at_least(:once).and_return('always')
+ expect(subject).to receive(:retry_when).at_least(:once).and_return(['always'])
end
it 'returns true' do