summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Tsiolis <tsiolis.g@gmail.com>2018-03-22 17:16:20 +0200
committerGeorge Tsiolis <tsiolis.g@gmail.com>2018-03-22 17:24:21 +0200
commitd72527c8105a2850a7f36410ced977427b38f889 (patch)
tree53a4f1ab254505fb7ad574eee8595c419289f07c
parent3f07ba161c732c9e9545a92a70ceca8b66e50e65 (diff)
downloadgitlab-ce-d72527c8105a2850a7f36410ced977427b38f889.tar.gz
Update dashboard milestones breadcrumb link
- Add milestone path to `/dashboard/milestones` breadcrumb link (which was causing 404 error) - Add milestone name to `/dashboard/milestones` breadcrumb - Add whitespace after the milestone name
-rw-r--r--app/views/shared/milestones/_top.html.haml5
-rw-r--r--changelogs/unreleased/add-milestone-path-to-dashboard-milestones-breadcrumb-link.yml5
2 files changed, 8 insertions, 2 deletions
diff --git a/app/views/shared/milestones/_top.html.haml b/app/views/shared/milestones/_top.html.haml
index 6006ab8b43f..f302299eb24 100644
--- a/app/views/shared/milestones/_top.html.haml
+++ b/app/views/shared/milestones/_top.html.haml
@@ -1,4 +1,5 @@
-- page_title milestone.title, "Milestones"
+- page_title @milestone.title
+- @breadcrumb_link = dashboard_milestone_path(milestone.safe_title, title: milestone.title)
- group = local_assigns[:group]
@@ -17,7 +18,7 @@
Milestone #{milestone.title}
- if milestone.due_date || milestone.start_date
%span.creator
- &middot;
+ &nbsp;&middot;
= milestone_date_range(milestone)
- if group
.pull-right
diff --git a/changelogs/unreleased/add-milestone-path-to-dashboard-milestones-breadcrumb-link.yml b/changelogs/unreleased/add-milestone-path-to-dashboard-milestones-breadcrumb-link.yml
new file mode 100644
index 00000000000..015bee99170
--- /dev/null
+++ b/changelogs/unreleased/add-milestone-path-to-dashboard-milestones-breadcrumb-link.yml
@@ -0,0 +1,5 @@
+---
+title: Update dashboard milestones breadcrumb link
+merge_request: 17933
+author: George Tsiolis
+type: fixed