summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Zallmann <tzallmann@gitlab.com>2018-11-13 11:51:48 +0000
committerTim Zallmann <tzallmann@gitlab.com>2018-11-13 11:51:48 +0000
commit9804df11ac5d4f36500b7ea97c80ea4275465e9b (patch)
tree4c9bead2e3317f1a35e307a25f62d1b9b72f20c1
parentb45a3033b8a34b060d5dba506fb4e7d895b6ea98 (diff)
parent3ac4e9ece78216f8c25c8b4d79749bc8294f87c1 (diff)
downloadgitlab-ce-9804df11ac5d4f36500b7ea97c80ea4275465e9b.tar.gz
Merge branch 'docs-fl-define-vuejs-expert-role' into 'master'
Defines Vue.js Expert Role See merge request gitlab-org/gitlab-ce!21922
-rw-r--r--doc/development/fe_guide/vue.md8
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/development/fe_guide/vue.md b/doc/development/fe_guide/vue.md
index f6cbd11042c..ccfd465531a 100644
--- a/doc/development/fe_guide/vue.md
+++ b/doc/development/fe_guide/vue.md
@@ -221,6 +221,14 @@ const vm = mountComponent(Component, data);
The main return value of a Vue component is the rendered output. In order to test the component we
need to test the rendered output. [Vue][vue-test] guide's to unit test show us exactly that:
+## Vue.js Expert Role
+One should apply to be a Vue.js expert by opening an MR when the Merge Request's they create and review show:
+- Deep understanding of Vue and Vuex reactivy
+- Vue and Vuex code are structured according to both official and our guidelines
+- Full understanding of testing a Vue and Vuex application
+- Vuex code follows the [documented pattern](./vuex.md#actions-pattern-request-and-receive-namespaces)
+- Knowledge about the existing Vue and Vuex applications and existing reusable components
+
[vue-docs]: http://vuejs.org/guide/index.html
[issue-boards]: https://gitlab.com/gitlab-org/gitlab-ce/tree/master/app/assets/javascripts/boards